When editing a server you are only provided with buttons to execute various actions. With the addition of the feature added in #1116030: Add transparency as to which server instance settings are being edited for there is no easy way to get back to the page you are coming from if you chose not to execute one of the actions. A cancel link would provide an easy way to click-navigate back to the previous page without having to use the back button.

CommentFileSizeAuthor
#4 apachesolr-1117152-4.patch1.51 KBcpliakas
#1 apachesolr-1117152-1.patch1.33 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new apachesolr-1117152-1.patch1.33 KB

The attached patch adds the link.

elliotttf’s picture

elliotttf commented
Status: Needs review » Reviewed & tested by the community

Works as described.

cpliakas’s picture

cpliakas commented
Assigned: Unassigned » cpliakas
Status: Reviewed & tested by the community » Needs work

Thanks for reviewing. At Peter's suggestion, if we were to be paranoid the destination should be checked to see if it is an internal URL. Marking as "needs work" and will post another patch.

Thanks,
Chris

cpliakas’s picture

cpliakas commented
Status: Needs work » Needs review
StatusFileSize
new apachesolr-1117152-4.patch1.51 KB

Same functionality in #1, but with the !url_is_external() check.

pwolanin’s picture

pwolanin commented
Status: Needs review » Reviewed & tested by the community
cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Committed to the 7.x-1.x branch. ac62188.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.