I get notices 

notice: Undefined index: group in /Users/clemens/Sites/drupal/d6/sites/default/modules/annotate/views/annotate_handler_field_note.inc on line 37.
notice: Undefined variable: values in /Users/clemens/Sites/drupal/d6/sites/default/modules/annotate/views/annotate_handler_field_note.inc on line 37.

for line $this->query->add_where($this->options['group'], $where, $values);

CommentFileSizeAuthor
#3 annotations-1264214-1.patch555 bytesfranskuipers

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

According to http://views.doc.logrus.com/ add_where has 2 arguments: $group, $clause

It then shifts arguments of and tests for more arguments.

So I guess we can remove $values.

But why is it nagging about 

$this->options['group']
franskuipers’s picture

franskuipers commented

what is your version of views?

franskuipers’s picture

franskuipers commented
StatusFileSize
new annotations-1264214-1.patch555 bytes

Also in http://views.doc.logrus.com/classviews__query.html#88733d15379fa820cc588... :

$group The WHERE group to add these to; groups are used to create AND/OR sections. Groups cannot be nested. Use 0 as the default group. If the group does not yet exist it will be created as an AND group.

Removed non existing $values and $group = 0

Patch against branch master.

franskuipers’s picture

franskuipers commented
Status: Active » Needs review
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Assigned: franskuipers » clemens.tolboom

Thanks ... the patch looks ok to me!

I'll retest and the move on to D7 I hope :-)

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.