The attached patch fixes the 'no handler found' errors for the Amazon image, participant and title fields, and adds a filter for amazon item images (allowing the filtering out of products with no images). 6.x-1.x-dev already nearly works with views2, so this patch applies against the 6.x-1.x-dev (not 6.x-1.0-beta3).

CommentFileSizeAuthor
#4 amazon_image_filtering.txt4.05 KBmleicester
amazon_views_patch.txt4.34 KBmleicester

Comments

Anonymous’s picture

Anonymous (not verified) commented

You my friend have saved me hours of work tonight!

Thanks. I'm still testing it.

mleicester’s picture

mleicester commented
Version: 6.x-1.0-beta3 »
joemoraca’s picture

joemoraca commented

this patch did not apply for the 6.x-1.x-dev version today.

mleicester’s picture

mleicester commented
Title: Fixes for views2, additional of image filtering » Fixes for views2, addition of image filtering
StatusFileSize
new amazon_image_filtering.txt4.05 KB

The most important issue with amazon and views2 has now been fixed in 6.x-1.x-dev (setting info path in amazon_views_handlers). I've updated the patch so that it should apply again. It now fixes some minor views2 issues (e.g. adding common settings to field configuration form), and adds filtering to images.

mandclu’s picture

mandclu commented

This patch also allows for customizing (or removing) the labels in views, which was a big deal for me.

Works great for me so far!

The only other thing I'd like to have in Views for Amazon is a field for some kind of call to action, like "Buy It Now!". Ideally, just a customizable label that links to the Amazon page. I guess I could do this in the theming layer, but since everything else can be done by this module, I thought I'd float the idea, in case someone felt inspired to add it to the module.

mandclu’s picture

mandclu commented

Hmmm, one issue I'm seeing with Views is that with the product image, if I set link behavior to "A link to the product's Amazon page", when it's displayed the link actually points to the site root instead.

mandclu’s picture

mandclu commented

I did a little investigating into this issue abut the link for the images. It seems that the $values object sent to the render() function doesn't contain a property called 'detailpageurl', but does contain one called 'amazon_item_detailpageurl'. Unfortunately, just changing the 'field' value in $this->additional_fields['detailpageurl'] generated an SQL error, so I rewrote line 21 of views_handler_field_amazon_image.inc to be:

      $this->additional_fields['detailpageurl'] = array('table' => 'amazon_item', 'field' => 'detailpageurl', 'value' => 'amazon_item_detailpageurl');

Then, I just needed to change line 85 to be:

        $urlfield = $this->additional_fields['detailpageurl']['value'];

With those simple changes, the image seemed to wok as expected, for me at least.

eaton’s picture

eaton commented
Status: Needs review » Fixed

Committed. Thanks for the fixes!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.