Link within link conflicts - broken html rendering [#153289]

Just one more bug... :p

I hope this is a reasonable report of a bug; I have disabled ordering by weight on my version (via manual hack) as the client really doesn't need it and it would make things more complicated for them. Either way, the bug would still occur, and shouldn't, IMO, if weighting is enabled.

The problem - I have two alinks, thus:

Classico - points to "polished-plaster-finishes/classico"
finishes - points to "polished-plaster-finishes"

the problem is, the classico link renders like this:

<a href="/polished-plaster-<a href="/polished-plaster-finishes" class="" title="View our finishes">finishes</a>/classico" class="" title="Classico finish">Classico</a>

This should just be a link to the Classico page:

<a href="/polished-plaster-finishes/classico" class="" title="Classico finish">Classico</a>

but the classico link is created by alinks, and then the finishes alink is processed and gets input *inside* the classico link - the text "finishes" is replaced by the alink module with another link.

The solution as I see it is to prevent the alinks module from processing any text inside existing links. I don't however know how this would affect the use of different input filters/formats.

Comments

Comment #1

tic2000 commented 20 June 2007 at 22:24

I'll release a version to fix that when my test server will be up so I can test the release.
But I can tell you one situation that I can't fix. In your example if you have one string "finishes" and one that is something like "best finishes ever". finishes in the second string will be replaced too. I have a solution to this too, but it means that the case of the original string in the node won't be preserved, but replaced by the case used in alinks content generation page.

Comment #2

tic2000 commented 20 June 2007 at 23:54

Version 1.4-3 released.

Comment #3

tic2000 commented 9 July 2007 at 12:45

Status:

Active

» Closed (fixed)

Comment #4

mybinaryromance commented 7 April 2010 at 15:37

Version:	5.x-1.4-2	» 6.x-1.0-rc1
Status:	Closed (fixed)	» Active

this bug is in the current 6.x release (1.0 rc1), too. the upper bug was reported for 5.x-1.4-2

additionally there are replacements taken in <a>-attributes - if i set up alinks like this:

link 'myterm' to path 'mypath_myterm_someword'
link 'someword' to path 'someotherpath'

... the 'someword' in the href="mypath_myterm_someword" of the first link will be replaced, producing source code like
<a href="mypath_myterm_<a href="someotherpath">someword</a>">myterm</a>

even class names are replaced by corresponding alinks