In the permissions overview, the advpoll entry "add write-in votes" has a warning: "Give to trusted roles only; this permission has security implications".
Could you please detail what this is about? Only allowing trusted roles the ability to add write-in votes completely beats its purpose. What would be the security issue if we let anonymous users use write-in?
Allowing guests to write in comments for things we can't predict in advance (like "how did you find this website?") was for me the main reason why I started trying out advanced poll (since the default poll has no write-in). If there would be real security problems involved by allowing anonymous write-ins, then that's really a dealbreaker...
Comments
Comment #1
Michele Wickham commentedFrom the standpoint of injection or XSS attack, there is no security issue. The input from that field is sanitized using standard Drupal methods.
The concern with anon write-ins was that the lack of accountability might cause individuals to insert inappropriate content.
However, I did recently add a permission to limit write-in content from displaying in results. So in a sense this is no longer an issue.
So, that said, I believe your concern is valid. I will go ahead and restore the ability to allow write-in for anon users, but only when voting mode is 'normal' (default voting api behavior), and not allow it for unlimited or cookie-based voting mode to prevent abuse.
Comment #2
Michele Wickham commentedActually, anon users can use write-ins, but only while in 'normal' voting mode. It is always turned off when the setting is 'unlimited' voting as this enables users to vote again on page refresh.
Unlimited is one of those edge cases - for an entertainment site where accurate vote counting is not a priority, it's ideal, but allowing write-ins in this case would mean that a malicious user could add hundreds of write-ins without any accountability.
I hope this answers your concerns about this feature.
Comment #3
P3t3r commentedSo, someone using the "normal" anyway can just ignore the scary warning messages? Good to know. :-)
Comment #4
tripper54 commented