electoral list by role

I would also love this feature!

I'd love this feature too.

Here is a quick stab at implementing the ability to add users to the electoral list based on their role. I did some really quick testing right now but will do some more tomorrow.

Cool! I will look into this later today. It would be a great help if people who want to see this feature get in could test this patch and come with feedback. The Drupal handbook has all information you need: http://drupal.org/patch/apply, http://drupal.org/patch/review, http://drupal.org/node/28245

Thanks!

Okay I did a more thorough test of the various permission combinations and didn't find any functionality problems. Let me know if there are any suggestions on the implementation/style.

I gave the UI some thought... First I was thinking it might be better for the workflow if the electoral list admin options were on the edit page, maybe as a collapsible fieldset. But it might clutter it too much so I'm not sure about that. Then I thought about simplifying it (so it wouldn't ad so much clutter), maybe just checkboxes for all roles; "restrict voting to roles" or similar. Just thinking out loud...

If we stick with this implementation, which might be the best option, the wording on the buttons on the electoral tab could need some work, but that could be improved upon later.

Fair points. I tend to prefer the electoral list stuff on its own tab since the edit page is already pretty complicated.

I considered a checkbox option, but I thought it might be too big/messy if a site has a lot of roles. Plus I don't think it will be a big deal if you have to select a few roles to add and submit the form a few times.

Agree that the button text could be tweaked. I'm leaning towards "Add to electoral list" and "Clear electoral list", with some extra space between the buttons too. Or do you think the phrase "electoral list" should be changed to something clearer?

I don't know how much work it would be, but if it's simple we might borrow some code from the content admin page (/admin/content/node). Especially the checkboxed in front of a user and the select all checkbox to remove a lot of users, or even remove them by role with a select element:
------------------------------
Remove selected users
------------------------------
Remove users by role:
- Voter A
- Voter B
------------------------------

The wording on the buttons you suggested is much better.

I don't know how much work it would be, but if it's simple we might borrow some code from the content admin page (/admin/content/node). Especially the checkboxed in front of a user and the select all checkbox to remove a lot of users, or even remove them by role with a select element:
------------------------------
Remove selected users
------------------------------
Remove users by role:
- Voter A
- Voter B
------------------------------

The wording on the buttons you suggested is much better.

Okay I committed it - I'll save the removing option for another issue.

http://drupal.org/cvs?commit=66948