Closed (fixed)
Project:
Advanced Help
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Aug 2008 at 05:46 UTC
Updated:
31 Oct 2008 at 19:02 UTC
Jump to comment: Most recent file
Comments
Comment #1
redndahead commentedIt should say "If someone wants to add &path& and not have it replaced they can use
&path&"Comment #2
redndahead commentedI would prefer the paths to change in advanced help, but in case someone wants a little hack to get that path in their help files using js here is what I use:
Comment #3
redndahead commentedWill be submitting the patch shortly. Just wondering if you would like the using-advanced-help.html file to only use the &path:&, have instructions for both ways or use &path:& but say something about the path: being the old way of doing things?
Also would you like me to update the current advanced_help help files to reflect this new syntax?
Comment #4
merlinofchaos commentedIt should document both and mention path: as being the 'old' way of doing things.
Comment #5
redndahead commentedHere is the patch. Pretty straightforward mainly needs a review on the language of the help topic on using tokens.
Comment #6
merlinofchaos commentedHn,mmm. The way this is implemented worries me. & is a legal character in a URI and you did &path:foo& rather than &path& foo like I was expecting. Does that break if & is part of the URL?
Comment #7
redndahead commentedHmm thought I replied to this already. It definitely does. Made the change, it should now be:
&path&myfile.jpg
&base_url&myfile.jpg
&topic:module/topic&
The module name and topic would not be allowed to have an & in them. Is this even allowed? If this is going to cause a problem maybe we can do:
&&path:foo&&
&&base_url:foo&&
&&topic:module/topic&&
Preference? Both patches are attached.
Comment #8
merlinofchaos commented& is not valid in a module name and we can arbitrarily say it's not valid in a topic name. This looks better, I'll go with this later this week. Thanks!
Comment #9
redndahead commentedThe previous patch had a missing .'/' in the path url. This one corrects that and adds some cleanup.
Comment #10
merlinofchaos commentedFinally committed. Thanks!
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.