In the naked style, there is a vertical border that separates the left column from the right column. The right column is where the body of the post is. Unfortunately, the left column has been given the border. This means that, if the right column has more content than the left column, the border will never extend to the right body's height. You can see an example in the attached screenshot.
And, repeating what I said in email:take a look here. note the "Login or register". that's where hook_links would normally go, right? notice how there's a left-border to it, that links to the comment's left border? that doesn't happen in the advanced forum implementation.
Finally, as also seen in the screenshot, the mail icon is not transparent.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | blue_lagoon_wrap_it_up.patch | 2.64 KB | dvessel |
| #3 | _323631_goonmage.patch | 1.97 KB | morbus iff |
| Picture 3.png | 229.23 KB | morbus iff |
Comments
Comment #1
michelleIf I put the border on the right column, we'll have the same problem in reverse. This is why blue_lagoon uses an image for the background. I didn't want to use an image for naked. Do you have a suggestion on how to fix it without an image?
As to the icon, yeah, I noticed that on one of my sites. Haven't had a chance to ask the designer to fix it.
Michelle
Comment #2
morbus iffMichelle: you won't have the same problem in reverse. This was never a problem in the Let's Change The Game forum design - it was already something I tested and catered to. The short answer is: always set a minimum-height on the post container. This minimum-height should be as if the forum avatar was added. For those without avatars and a short body, yep, you will get extra whitespace (see this particular post for an example).
Blue Lagoon uses an image? Ugh. I /was/ gonna use Blue Lagoon as my default, but the image rules that out.
Comment #3
morbus iffHere's a fix for Blue Lagoon. Removes the need for the image (which you'll have to do in CVS manually).
Comment #4
michelleI made one change to put the outside borders back that this patch removed and committed it to both branches.
Thanks, that background image has been a thorn in my side for longer than AF has been a module. :)
Michelle
Comment #5
dvessel commentedThis fixes this issue: http://drupal.org/node/325675
This changes the markup. It may be rough but I'm just uploading this to see if it fixes the issue. Applies only to blue_lagoon. Hope I checked out the right version.
Comment #6
michelleThis isn't strictly a dupe but it was the patch in here that caused the problems in #325675: Make forum threads work properly in IE without min-height or background image so I'm consolodating the issues.
Michelle