Issue Summary
Drupal 11.4 changed the system.performance configuration keys from css.gzip / js.gzip to css.compress / js.compress as part of the related Drupal core change in #3526344.
AdvAgg still reads and writes the legacy *.gzip keys.
On Drupal 11.4.x, when the site configuration contains the new css.compress / js.compress keys, AdvAgg continues to check the old css.gzip / js.gzip keys. As a result, AdvAgg can incorrectly determine that CSS/JS compression is disabled, even when compression is enabled in Drupal core.
This can cause compressed aggregated CSS/JS files not to be generated, without any error.
The AdvAgg settings form is also affected:
- Default values are read from the legacy css.gzip / js.gzip keys.
- Saving the form writes to the legacy keys instead of the current css.compress / js.compress keys.
Steps to reproduce
- Install Drupal 11.4.x and enable AdvAgg.
- Enable CSS and/or JavaScript compression in Drupal's system.performance configuration, or import configuration containing:
- css.compress: true
- js.compress: true
Expected result
AdvAgg should use Drupal 11.4.x's current system.performance configuration keys and honor css.compress / js.compress when compression is enabled.
The AdvAgg settings form should also read from and save to the current configuration keys.
Actual result
AdvAgg reads the legacy css.gzip / js.gzip keys.
When those keys are not populated on a Drupal 11.4.x site, AdvAgg can treat compression as disabled even though css.compress / js.compress are enabled in Drupal core.
The AdvAgg settings form can also write the legacy keys instead of the current keys.
Proposed resolution
Update AdvAgg to:
- Read css.compress / js.compress on Drupal 11.4.x.
- Fall back to css.gzip / js.gzip where necessary for compatibility with supported older Drupal versions.
- Update the AdvAgg settings form to use the current *.compress configuration keys.
- Add or update automated tests to cover the Drupal 11.4.x configuration keys and, where applicable, backward compatibility with older configuration.
| Comment | File | Size | Author |
|---|---|---|---|
| advagg_gzip_compress_key_11_4.patch | 3.34 KB | bharathi vediyam |
Comments