It's async js so the order is not guaranteed.

CommentFileSizeAuthor
#7 advagg-2447067-7-async-in-header.patch3.17 KBmikeytown2
#6 advagg-2447067-6-async-in-header.patch3.2 KBmikeytown2
#4 advagg-2447067-4-async-in-header.patch3.19 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented

Should also force to footer.
maybe sort alphabetical as well so they are always in the same order in the aggregate.

cussack’s picture

cussack commented

I stumbled upon this while researching an async bug (that is fixed in 7.x-2.10, thanks)

async scripts should not be forced into footer. async will never block DOM building, so the best option would be to force them to header (if at all) to load them early and achieve best responsiveness of the page.

mikeytown2’s picture

mikeytown2 commented
Title: Group async js together » Group async js together in the header
mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new advagg-2447067-4-async-in-header.patch3.19 KB

Mind testing this out?

The setting is in the advagg_mod module. Go to admin/config/development/performance/advagg/mod Under "Adjust javascript location and execution" there is "Experimental Settings" and under that is the Asynchronous JavaScript Execution: Group together in the header checkbox.

Status: Needs review » Needs work

The last submitted patch, 4: advagg-2447067-4-async-in-header.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review
StatusFileSize
new advagg-2447067-6-async-in-header.patch3.2 KB
mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed
StatusFileSize
new advagg-2447067-7-async-in-header.patch3.17 KB

Committed this patch.

  • mikeytown2 committed 49e61c2 on 7.x-2.x 
    Issue #2447067 by mikeytown2: Move async to header in the same group.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.