Add db cache for advagg_hooks_implemented module_implements calls. [#1996828]

Calling module_implements loads up files. We don't want to do this. Thus this needs to be cached.

Comment	File	Size	Author
#4	advagg-1996828-4-add-in-full-cache.patch	7.2 KB	mikeytown2
#4
#1	advagg-1996828-1-cache-module-implements.patch	863 bytes	mikeytown2
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mikeytown2 CreditAttribution: mikeytown2 commented 16 May 2013 at 23:59

Status:

Active

» Fixed

File	Size
advagg-1996828-1-cache-module-implements.patch	863 bytes

Shaves ~10ms off of the request for an advagg cache hit. Following patch has been committed

Comment #2

mikeytown2 CreditAttribution: mikeytown2 commented 17 May 2013 at 00:23

I've gotten this down to core: 7ms, advagg: 9ms using microtime(TRUE) timers. Using xdebug it shows core: 32ms, advagg: 42ms. ~30% slower when we are talking about 2ms isn't a big issue in my opinion. If I wanted to get more out of it I could cache advagg_merge_plans or _advagg_aggregate_css/js but that would give me a lower cache hit ratio for that cache due to inlined output. Nonetheless something to think about.