Closed (fixed)
Project:
Advanced CSS/JS Aggregation
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Feb 2012 at 22:45 UTC
Updated:
11 Apr 2012 at 01:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
mikeytown2 commentedComment #2
mikeytown2 commentedRe-worked the cdn exception and made the comment more descriptive.
Comment #3
mikeytown2 commentedThis patch has been committed.
Comment #4
udvranto commentedGetting this error with the latest dev:
Comment #5
mikeytown2 commentedThanks for the heads up. This patch has been committed.
Comment #6
doublejosh commentedMind pointing out where I can read up on the actual issue being noted by this debug?
Sounds like the problem is not actually present, but would like to understand better. I got it while installing the CDN module; assuming that's the norm.
Thanks.
Comment #7
mikeytown2 commented@doublejosh
Example of this check doing the correct thing #1441294: Theme hook is not in the correct place.
Comment #8
doublejosh commentedHey Mike, I'm trying to understand what the actual problem is that the debug looks to avoid.
Presume it's testing to be sure advagg is last (which it is, as noted by you saying the debug looks fine.)
Comment #9
mikeytown2 commentedAdvAgg is making sure its last. As for why its throwing an error for you here is odd... Any way you could debug inside of the advagg_install_theme_registry_location() function for me since I can't repo this on my local box?
Comment #10
mikeytown2 commented@doublejosh
Any help with debugging this?
Comment #11
doublejosh commentedTossed in a few dsm() for $function within hook_requirements...
Initially $function is set to: advagg_processor
After
if (module_exists('cdn') && function_exists('cdn_theme_registry_alter')) {it's set to: ctools_preprocess_pageWithin that hook it appears like CDN does not register a preprocess_page function in this list. However cdn/cdn.fallback.inc includes a cdn_preprocess_page() function.
The CDN registry_alter attempts to make it last...
Comment #12
mikeytown2 commentedIs this against the latest dev?
http://drupalcode.org/project/advagg.git?a=search&h=refs%2Fheads%2F6.x-1...
I do have some checks against the CDN module but not both in that form.
http://drupalcode.org/project/advagg.git?a=search&h=refs%2Fheads%2F6.x-1...
(looks like clicking through to the line # is broken)
Comment #13
doublejosh commentedSeems to me you actually want CDN to run after advagg. I'd like to serve my aggregated CSS and JS from CDN.
I'll make a patch that doesn't attempt to pop-off the cdn_preprocess_page() function and removes the debug.
Something I'm missing?
Comment #14
doublejosh commentedYeah, that's what I was referring too.
I'm suggesting you remove the CDN check as that's running after AdvAgg anyhow.
Your check is failing because the CDN preprocess_page isn't there yet and you're stripping out whatever happened to be at the bottom (in my case ctools).
Maybe you tweaked the weight in your setup?
Comment #15
mikeytown2 commentedThis code block
got replaced in #2 which has been committed. The new code looks like this:
http://drupalcode.org/project/advagg.git/blob/7d17df6d84c9fac4cbbceee940...
Comment #16
doublejosh commentedCripes.
I'll update to dev and re-check.
Comment #17
mikeytown2 commentedAny news on this?
Comment #18
doublejosh commentedGot a big pile of requests on my module today. Will be looking at this this week.
Comment #19
mikeytown2 commentedGoing to mark this as fixed as I believe it is now.