The admin theme I am using (Seven) has it's own stylesheet for vertical-tabs. This is added in seven.info:

stylesheets[all][] = reset.css
stylesheets[all][] = style.css
stylesheets[all][] = vertical-tabs.css

This causes the original stylesheet from the vertical_tabs module to NOT be loaded onto the page at all, because vertical-tabs.css is the same name as the file from the stylesheet in the vertical tabs module (I think this is quite a common way for themes to be able to completely override module stylesheets).

With advagg enabled, it seems that the vertical-tabs.css from the vertical_tabs module is also getting included on the page, and so Seven's vertical-tabs.css override isn't working correctly.

Comments

mrfelton’s picture

mrfelton commented
Title: Order of module css files vs theme css » module stylesheets not being overridden by theme stylesheets
mrfelton’s picture

mrfelton commented

See http://drupal.org/node/263967

mikeytown2’s picture

mikeytown2 commented

I'll need to look into this but my initial guess has to do with the advagg_merge_css function. Mind uploading the text from watchdog when doing ?advagg-debug=1 on a page that has this issue?

mikeytown2’s picture

mikeytown2 commented

one more test to do: try it with ?advagg=0 and see if the CSS is correct in that case. also try with ?advagg=-1

mikeytown2’s picture

mikeytown2 commented
Status: Active » Postponed (maintainer needs more info)

looking at the core function and mine; the override functionality is in them both. I tested and it is removing module files.

advagg_process_css
drupal_get_css

mikeytown2’s picture

mikeytown2 commented
Status: Postponed (maintainer needs more info) » Active

I'm able to repo this

mikeytown2’s picture

mikeytown2 commented

advagg output

<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/vertical_tabs/vertical_tabs.css" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/seven/reset.css" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/seven/style.css" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/seven/vertical-tabs.css" />

core output

<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/seven/reset.css?j" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/seven/style.css?j" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/seven/vertical-tabs.css?j" />

issue is with seven_preprocess_page; it unsets vertical_tabs.css. If it named vertical-tabs.css the same as the module name (use an underscore instead of a dash) then it works as it should.

mikeytown2’s picture

mikeytown2 commented

Patch for seven to fix this issue
#1142770: Seven Theme - Performance tweek & advagg fix

mikeytown2’s picture

mikeytown2 commented
Title: module stylesheets not being overridden by theme stylesheets » Seven Theme unnecessary modifies the CSS array
Component: CSS Compression » Documentation
Category: bug » support
mikeytown2’s picture

mikeytown2 commented
Status: Active » Closed (works as designed)

issue is on the front page for known issues. waiting for seven to commit that patch

mrfelton’s picture

mrfelton commented

I've committed your fix to the Seven theme. Thanks.
http://drupal.org/node/1142770#comment-4420028