Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
For some reason, there is an extra -settings bit in the "Admin Toolbar Search settings" path, which should probably be removed, since that's not the convention:
/admin/config/user-interface/admin-toolbar/admin/config/user-interface/admin-toolbar-search-settings/admin/config/user-interface/admin-toolbar-tools
Steps to reproduce
Visit the three Admin Toolbar pages, and see an extra -settings in /admin/config/user-interface/admin-toolbar-search-settings.
Proposed resolution
Remove -settings from this path:
Now:
/admin/config/user-interface/admin-toolbar-search-settings
Proposal:
/admin/config/user-interface/admin-toolbar-search
Remaining tasks
- Update the path
- Update the test
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | previous-path.png | 69.91 KB | chhavi.sharma |
| #4 | altered-path.png | 78.32 KB | chhavi.sharma |
Issue fork admin_toolbar-3523066
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
chhavi.sharma commentedComment #4
chhavi.sharma commentedRemoved -settings from Search settings page path. The issue needs review.
Previous Path:
Altered Path:
Comment #5
ressaThanks @chhavi.sharma it's much better now. It does look like the test needs to be updated as well :)
It's this one:
admin_toolbar_search/tests/src/Functional/AdminToolbarSearchSettingsFormTest.phpComment #7
dydave commentedIndeed, great catch @ressa! 👍
I've just made the change to the MR and it is back to passing 🟢
Glad we have tests in place 🙂
Moving issue back to Needs review, for a final confirmation, before it gets merged 👌
Thanks again for all the great help!
Comment #8
ressaThanks @dydave, for a speedy reply and update as always!
The path is fixed and the tests are green (I agree, tests really are great, when they catch these small, easily overlooked details) so let's ship it! 🚀
Comment #10
dydave commentedThanks a lot @ressa and @chhavi.sharma for your great help on this issue! 🙏
Following your confirmation at #8, I went ahead and merged the changes above at #9 👌
Another issue to scratch off our list, included in the next release! 🥳
Getting closer to the release date ... Let's see what else we could squeeze in 😅
Thanks again @ressa for suggesting these issues and @chhavi.sharma for your help with the code changes!
Comment #11
ressaThanks @chhavi.sharma and @dydave for fixing this so fast, with lightning speed! ⚡
Awesome to get another little improvement included, before release. Thanks!