Problem/Motivation

I randomly saw that the toolbar search input has no corresponding id for labeling the input.

Steps to reproduce

activate admin_toolbar_search module and validate any page with toolbar.

Proposed resolution

add a label element, maybe visually hidden for screenreader support so there is no need for an explicit aria-labeledby

CommentFileSizeAuthor
2021-05-14 14_44_41-Test_ Datentabelle _ Hansestadt Wesel am Rhein.png25.12 KBsunlix

Comments

sunlix created an issue. See original summary.

dydave’s picture

dydave commented
Status: Active » Closed (outdated)

Could you please try with the latest version of the module?

I have just tested this with admin_toolbar_search:3.5.3 and confirmed the search text field had an associated label tag which is indeed visually-hidden, as suggested in the issue summary 🟢, see:

<div class="js-form-item form-item js-form-type-search form-type--search js-form-item- form-item-- form-item--no-label">

  <label for="admin-toolbar-search-input" class="form-item__label visually-hidden">Search</label>
  <input placeholder="Admin Toolbar quick search" accesskey="a" type="search" id="admin-toolbar-search-input" size="30" maxlength="128" class="form-search form-element form-element--type-search form-element--api-search ui-autocomplete-input" autocomplete="off">

</div>

 
Closing issue as outdated, for now.

Thanks again for your help and contributions.