Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
In the 8.x-1.x branch, the search input is a button that toggles a text field to do the search.
In the 8.x-2.x and 3.x branch, it is displayed directly a text input field in the toolbar
As now we have configuration form, it is a good idea to let the user choose what will be displayed
Proposed resolution
Create a config form to the admin toolbar search so the user can choose the best approach is.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3211161-8.patch | 11.61 KB | neclimdul |
| #8 | 3211161-8.interdiff.txt | 5.79 KB | neclimdul |
| #5 | 3211161-5.patch | 8.56 KB | paulocs |
| #5 | interdiff-1-5.txt | 367 bytes | paulocs |
| #3 | Screenshot from 2021-04-28 10-41-40.png | 65.49 KB | marcusvsouza |
Comments
Comment #2
paulocsI have a patch for it.
Notice that the user has to flush the cache after change the configuration form.
Cheers, Paulo.
Comment #3
marcusvsouza commentedThe patch applied properly and works as expected.
Comment #5
paulocsNew patch and interdiff.
Comment #6
guilhermevp commentedJust moving to RTBC as it pass in test and the functionality already works as shown by comment #3.
Comment #7
adriancidThanks, I will review it later.
Comment #8
neclimdulThat's a pretty easy fix, just add a cache tag to the cache information for the section. :)
Also fixed line endings, added the config entry in info, and added a test to show the cache tag and the toggling work.
Comment #9
paulocsLooks good!
Thanks for the improvement @neclimdul.
Comment #11
adriancidThanks
Comment #13
romainj commentedComment #15
romainj commentedComment #16
neclimdulConfused as to why this keeps getting marked fixed and showing back up in my feed.