Because the suppress code may have to run every request, I think it's a little silly to put the includes for each module in separate files that would have to be included. Especially when the code is not that large in the include files.

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

The primary reason I do this is so that support for a new module can be easily dropped in my creating a 'includes/MODULE.inc' file, such as toolbar.inc. The other benefit (probably more so for D6 than D7) is that the files don't get included unless the modules exist on the site.

IMHO putting everything in a single module file can make it hard to find module specific integration code and just makes the whole code harder to read.

If there is a performance issue I may concede the matter, but if it's just a case of coding style preferences then it would be hard to see the need to change.

However I am open to change if necessary.

Cheers,
Deciphered.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Closed (duplicate)

Marking as duplicate of #1125012: Application to add Dave Reid as a co-maintainer