Closed (duplicate)
Project:
Administration menu
Version:
6.x-3.0-alpha4
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2010 at 12:57 UTC
Updated:
27 Nov 2015 at 14:46 UTC
Jump to comment: Most recent
Comments
Comment #1
sunThat list comes from Devel module. It's the same list as in Devel module's Switch user block.
Comment #3
dwightaspinwall commentedI can't see where devel_switch_user_list() is called from admin_menu. The only reference to this function is within devel.module itself, for the Switch User block. I'd like to disable this, as the query takes one second on our site, and we have many users with switch user permission.
I'd be happy to submit a patch if you can tell me who calls devel_switch_user_list().
Comment #4
sunSearch for "switch_user_list" only in order to find it.
However, admin_menu 1.x won't get any further, non-critical features and improvements, since 3.x has superseded a long time ago already.
Comment #5
dwightaspinwall commentedI'm reclassifying this issue as a bug on the 3.x branch. A one second delay on every page load is unacceptable in my book (against 200,000 users, but lots of site have this many users or more), so the solution is either to remove the list, allow disablement in config, or improve query performance.
I'd be happy to provide a patch -- let me know your thoughts on best approach.
Comment #6
sunThanks for taking the time to report this issue.
However, marking as duplicate of #293768: Allow to enable/disable menu additions. You can follow up on that issue to track its status instead. If any information from this issue is missing in the other issue, please make sure you provide it over there.
Comment #7
jwilson3A couple years late probably, but I've successfully reduced the >1 second delay by simply changing the LEFT JOIN to an INNER JOIN on the query that generates the list of users one can switch to.
#2624370: Increase query performance of devel_switch_user_list