Hide disabled menu items

erm... and where are those items set to hidden?

Ok, but could you please elaborate on for performance reasons? Is there something special in 6.x I'm not yet aware of?

Successful patch. Thank you!

Yes, thanks!

Works nicely, thanks!

Setting back to needs review, could be good if this gets into the module. Admin menu is very handy but often it's interesting to hide certain menu items (like not to be used content types eg content profile, ...).

Is there any hope in getting a patch for 3x?

I don't think that this is the right approach. If you want to hide links, then you shouldn't grant access to them. In the case of content types, you can configure access permissions very granularly per role, for example. Same applies to everything else.

Links that have been customized to be hidden should already be excluded in 3.x.

You can't think of any good reasons why an item would be placed in the menu, but disabled? Breadcrumbs. Pathauto. There are a million things that make use of the menu structure, where you don't actually want a menu item to show up in the actual menu.

I think the more important question is, can you think of a case where someone would intentionally disable a menu item, but still want it to show up in the administration menu?

I've made small patch to implement this. Be sure to clear site cache after disabling menu items. Patch was made from latest CVS code at the moment.

This is strange, I can't reproduce tests failure on clean local site with latest Drupal 6 from CVS, SimpleTest 6.x-2.10 and latest Administration menu from CVS. Described configuration with last patch passes all 48 tests. Am I doing something wrong?

#11: admin_menu-6.x-3.x-hidden-items.patch queued for re-testing.

The patch in #11 works for me, and is much needed! Not sure what's going on with the tests, though.

admin_menu.admin_menu.module.hide-disabled.patch queued for re-testing.

#11: admin_menu-6.x-3.x-hidden-items.patch queued for re-testing.

I guess the main problem is that that the regular menu entires are copied and reorganized from admin menu.

Not the user-build menus preferences were used, but the modul given. So no hidden attributes are set in the database

Thank you #11

+++ admin_menu.inc	5 Aug 2010 10:24:51 -0000
@@ -22,8 +22,8 @@
+    if ((isset($data['link']['type']) && $data['link']['type'] == MENU_CALLBACK) || $data['link']['hidden']) {

I didn't test, but I'm pretty sure that this also removes all local tasks from the menu.

Powered by Dreditor.

I was able to reproduce the issue that the original submitter had. I have tested the patch in comment #11 and it worked as expected.
Firefox-3.6.13
Drupal-6.20
Postgresql-8.4
Admin menu-6.x-3.0-alpha4

I have also used the patch in comment #11 and it has worked as expected. I am running Drupal 6.20 on Firefox 3.6.13
Postgres 8.4
Admin menu: Version 6.x-3.0-alpha4

I have also used the patch in comment number 11, admin_menu-6.x-3.x-hidden-items.patch, and I found that it did what I expected it to do.
I used the following:
Mozilla Firefox 2.6.13
Drupal 6.20
Postgresql 8.4
admin_menu-6.x-3.0-alpha4

I've been guiding some students through testing this patch. We used the latest 6.x-3.0-alpha4 rather than CVS on Drupal 6.20 (I had Postgres 8.1 running for it). Patch #11 worked well for us, I think it's also a possible workaround for the long menus bug: http://drupal.org/node/687750

Interested in this ticket. I used OP's patch on 1.6 and it worked, and looked at the (rather simple) patch for 3.x-dev. Both seem good. Setting to reviewed & tested by the community to see if we can get a commit.

Tested manually, custom links don't work (at all) for me in D6. But well, that's a horrible mess anyway.

Unfortunately, the same issue seems to exist in D7, too. Attached patch adds tests that prove the bug exists (in a rudimentary form).

This works for me:

module version: 7.x-3.0-rc1
file: admin_menu.inc
row: 369
added: || $data['link']['hidden'] == 1

if (!$data['link']['access'] || $data['link']['type'] == MENU_CALLBACK || $data['link']['hidden'] == 1) {

hidden may be 0,1,-1

The solution in #30 worked for me against latest 7.x-3.x-dev (although the line number for the change is now 381)

Patch in #11 works just fine for D6 and I think it should really be included. @sun, as said on #24, this doesn't prevent local tasks from appearing on the admin menu.

Patch no longer applies to dev brach :(

+++ admin_menu.inc	30 Jan 2011 06:17:26 -0000
@@ -378,7 +378,7 @@ function admin_menu_links_menu($tree) {
-    if (in_array($data['link']['router_path'], array('admin/by-task', 'admin/by-module'))) {
+    if (in_array($data['link']['router_path'], array('admin/tasks', 'admin/index'))) {

This hunk is already part of #1097312: "Tasks" and "Index" links appear on the top-level and should be removed from this patch.

okay, patch re-rolled for latest dev. Added the fix from #30 and removed the line as per #36.

this will be super nice. for D6, should I retest #11, or wait to see if it gets committed for D7?

#37: remove_disabled_links_from_menu-282775-37.patch queued for re-testing.

Thanks for re-rolling.

Attached patch fixes the code and tests. Took over some code from #742184: Shortcut.module integration.

Thanks for reporting, reviewing, and testing! Committed to 7.x-3.x and 8.x-3.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

This fix will no be backported to 6.x-3.x.

Just installed 7.x-3.dev (March 9th 2012) today. I have disabled a bunch of menus in the structure section of navigation menu as I don't want authenticated users to see menus we don't want them to see.

I ran update, I have flushed all caches but the menu items still appear?

The expected behavior is backed up with automated tests, so something else must be wrong regarding #48.

Re-closing this issue.

Sorry to re-open, but just need to double check this.
I made a clean install to eliminate module clashes.
I can hide the majority of disabled menu items, but can not hide disabled items which are children of admin/structure/menu - is this the expected behaviour?

@hixster: Please create a new issue for that. Thanks.