On line 346, within the function addnode_widget, _add_subform is invoked in the following manner:

_add_subform($form, $subform, $fieldname, $atype, $subprefix, $usesuffix, $weight);

However, the variable $subprefix is never initialized in the function. The variable $prefix, on the other hand, is initialized but not passed as one of these parameters.

Furthermore, in the function _add_subform itself, the passed $subprefix variable is never used.

I am leaving this as a minor bug, I don't know yet (just started working with module) if this is significant. Would like you to comment.

Comments

Lionfish’s picture

Thanks for the feedback. Yeah, this code is a mess. This was basically the module I cut my teeth on, and I've tried several different routes to get it working (eg I originally started trying to get this working by embedding the html directly). I'll rewrite the code and fix a couple of the other issues listed. Thanks!

Lionfish’s picture

Version: 5.x-1.0 » 5.x-1.1
Status: Active » Fixed

Thanks, the code's still not perfect, but it's a bit better!

Anonymous’s picture

Status: Fixed » Closed (fixed)