The conceptual idea of having the form offer a sub-form as a choice is nice, but maybe practically it's easier and more elegant to open the subform (as you do) and then submit that (i.e. provide a local-submit button), if the submit passes, then feed the new value into the parent form - as you do. Graphically "shading" the parent form as the user is encouraged to fill - and submit - the subform would be icing on the cake :-)

This would solve the problem of sub-forms failing and silently causing the whole thing to fail on submission?

Comments

Lionfish’s picture

Lionfish commented
Version: 5.x-0.9 » 5.x-1.0

I see your point (I think the subform module is being worked on again, now - which does the seperate form in a form, with submit buttons - as you describe). "the problem of sub-forms failing and silently causing the whole thing to fail on submission" is one I think I can tackle. At the moment I'm not getting the value returned from the drupal_execute call, but that's just because I haven't got around to coding it yet :) Hopefully I can just get that, check if it's an error and handle it then.

Thanks for helping test the module :) Hopefully I'll be able to fix the current issues during the next week or so.

(PS Sorry if you ended up using v0.9. v1.0's identical except I removed a print_r statement I'd accidentally left in)

markfoodyburton’s picture

markfoodyburton commented

No worries, I did try both .9 and 1.0, but with similar results. Sometimes the form submits fine - other times it fails :-(

As of yet, I haven't been able to determine whats causing it to pass/fail :-(

I'll keep my eye on subform - which may be what I want, but I'm greedy, I suspect I'll want both :-)))

If there is stuff I can do to help, let me know

Cheers

Mark.

Lionfish’s picture

Lionfish commented
Version: 5.x-1.0 » 5.x-1.1

Hopefully the new version (1.1) fixes the above bug, but I've not changed the way it works in general (allowing subforms to be submitted first).

markfoodyburton’s picture

markfoodyburton commented

Thanks.... :-)
Cheers

Mark.