Closed (fixed)
Project:
AdaptiveTheme
Version:
8.x-5.1
Component:
Theme Settings
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Nov 2022 at 04:59 UTC
Updated:
20 Jan 2024 at 17:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dribgnikcom commentedError log shows the following:
Error: Call to undefined function drupal_get_path() in at_color_scheme_form_submit() (line 98 of /home/website.com/web/themes/contrib/adaptivetheme/at_core/forms/color/color_submit.php).I guess I should post this bug at the Color module issues tracker. Please close.
Comment #3
dribgnikcom commenteddrupal_get_path()is gone from Drupal 10, and the author of the color module needs to update the file to reflect the change.Comment #4
markusk commentedAdded link to related issue in color project queue.
Comment #5
markusk commentedShortened issue subject for readability.
Original subject was
Save Color Scheme - "The website encountered an unexpected error. Please try again later." (Error: Call to undefined function drupal_get_path() in at_color_scheme_form_submit() (line 98...)Comment #6
bart lambert commentedWhy won't this be fixed?
drupal_get_path() is removed and can't be called upon in D10.It is still present in the color_submit.php file which is part of AdaptiveTheme.
So as far as I understand it should at least be corrected here before we can carry on.
Comment #7
bart lambert commentedComment #8
roshni27 commentedplease review the patch.
Comment #11
keshavv commentedThank you for the patch. But the patch will not work, Because it removed the trailing slash as well, Also there is one more occurrence.
So I have created the MR to fix issues from all places.
Please review,
Thank you.
Comment #12
shweta__sharma commentedUpdated issue summary with the actual error.
Comment #13
bart lambert commentedAfter correcting the color_submit.php file according MR4! following error is thrown when I want to change te colors:
ArgumentCountError: Too few arguments to function Drupal\Core\Asset\CssOptimizer::__construct(), 0 passed in /data/sites/web/modelspoorhobbybe/subsites/empa2019.modelspoorhobby.be/themes/contrib/adaptivetheme/at_core/forms/color/color_submit.php on line 132 and exactly 1 expected in Drupal\Core\Asset\CssOptimizer->__construct() (line 34 of core/lib/Drupal/Core/Asset/CssOptimizer.php).
Comment #14
janoka commentedReviewed: The code in the patch is good, as the previous error message has disappeared from the log.
Once applied, only the
CssOptimizererror remains.I think the patch covers the original bug.
Comment #15
sd123 commentedOnly the merge request works but it leads to the following error as commented earlier:
Comment #17
mattbloomfield commentedThis has been fixed and will make its way into a new release later today
Comment #18
mattbloomfield commented