I'm trying to make a "minimal kit" subtheme using AT theme generator. It doesn't work right after generation. I'm not sure if it should, but here's what I got

1. The latest 8.x dev installed (git clone) and activated
2. Appearance/settings/generate, select "minimal kit" for Type, name Whatever, no changes to Options
3. Goto List, install and set Whatever as default
4. On the frontpage:

Notice: Undefined variable: suggestions_layout in at_core_preprocess_page() (line 473 of themes/adaptivetheme/at_core/at_core.theme).
Notice: Undefined variable: layout_css in at_core_preprocess_page() (line 516 of themes/adaptivetheme/at_core/at_core.theme).
Bummer, something went wrong. Check the themes Appearance settings, maybe the layout is borked or has been disabled?

5. On the whatever settings page:

Notice: Undefined index: breakpoints:toolbar in Drupal\Core\Cache\DatabaseBackend->getMultiple() (line 87 of core/lib/Drupal/Core/Cache/DatabaseBackend.php).
Notice: Undefined index: in include_once() (line 25 of themes/adaptivetheme/at_core/forms/layout/layouts.php).
Warning: Invalid argument supplied for foreach() in include_once() (line 119 of themes/adaptivetheme/at_core/forms/layout/layouts.php).

"Layouts" section is empty, switching it off helps to get rid of one of the errors (Notice: Undefined variable: suggestions_layout in at_core_preprocess_page()) but the rest is the same.

"Standard kit" subtheme works fine.

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Assigned: Unassigned » Jeff Burnz

Correct, the Minimal kit needs updating to work with the new layout system and other newer components, I will commit to updating it in the next day or two. Those notices and errors are what I would expect, I haven't tested it since I updated the layout system and have only really tested the Standard kit and Skins.

Jeff Burnz’s picture

Jeff Burnz commented

I have disabled the minimal kit for now, it will be back soon, its still broken and I don't want anyone crashing their site by trying to run it.

All it needs is updating to use the new layout system, its not a big task but there has been so much other work to take care on in recent weeks. Note I am basically working on this theme full time at the moment, so it will get done.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Fixed

This is now fixed, I have significantly refactored the Theme Generator to make it easier to maintain the code and easier to read, also all the options now work.

Minimal themes are also now really minimal, just a layout really, no style CSS is loaded by the theme at all, so you get a very raw theme.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Fixed » Closed (fixed)

Please note I have in the latest commit removed the option for the minimal theme again. After long reflection on the minimal theme it needs a different approach now we are loading assets entirely from hook functions rather than info files, this rather complicates having a minimal option in the generator, and skins, and clone etc, its one option to many at the moment. In due course I may revisit the minimal concept however going forward this is not a high priority, I have to focus on the core purpose and capability of the theme and that revolves entirely around the standard theme type since this is what most users will end up using.