ad_owners does not uninstall properly

It's pretty pathetic that the developer hasn't even responded to this one.

Terribly pathetic indeed. The guy should be fired, or at least get a cut in pay.

I apologize- I was disrespectful. It is obviously an accidental coding oversight that could happen to anyone.

But it is still a very critical issue (part of a modules functionality is for it to be able to be uninstalled cleanly so it can be reinstalled cleanly). In my case, I was trying to debug other issues I am having with the Ad module and wanted to uninstall and reinstall everything. Then I got distracted trying to find out why ad owners didn't uninstall correctly.

I just think, given the nature of the issue, you could have at least acknowledged the original post.

Sure, the bug should be fixed. Take a look through the module's issue queue, there's countless bugs that should be fixed. Truth be told, I maintain my modules in my spare time, something that I've had none of for far more months than is healthy. Bugs that affect me personally on my own websites get fixed quickly, bugs that affect other people other than myself, there's no guarantee. But if you think you're owed something because you're freely using code that I've written and maintained over many years and released under the GPL, think again.

> I just think, given the nature of the issue, you could have at least acknowledged the original post.

And I think you're an idiot. There we have it.

Anyway, fixed:
http://drupal.org/cvs?commit=370068

This commit (now Git Commit c1d12cf) added a lot of unintended code to the module and is directly responsible for at least #1060100: Ad specifies body font height to 12px and #821160: user warning: Unknown column 'sitekey' in 'where clause'. It should be reverted (git revert c1d12cf03420bb45b8d11b9820c5b68d1313f283) and only the uninstall part re-applied.

Then the rest of the patch needs to be evaluated for re-inclusion.

Reopening.

Commit c1d12cf reverted, "install" patch re-added.