The permission should be "view advertisments" rather than "show advertisements." This is the correct phrase and it is inline with other Drupal permissions.

CommentFileSizeAuthor
#2 ad-authfix.patch10.52 KBjohn franklin

Comments

john franklin’s picture

john franklin commented

The "show advertisements" allows a user to see delivered ads. A "view advertisements" permission should allow a user to see the main node with the ad, its assigned channels, premiere status, viewing and click-thru statistics, etc. Regular users should *never* be allowed to access that information.

I would suggest we make two changes to the permissions:

1. Invert the meaning of "show advertisements" and make it "exempt from advertising" and
2. Add the normal array of "[ view | edit | create | delete ] [ any | own ] advertisements"

john franklin’s picture

john franklin commented
Version: 6.x-2.0-rc1 » 6.x-3.x-dev
Category: task » feature
StatusFileSize
new ad-authfix.patch10.52 KB

This patch was posted in issue #597116: ad module not displaying ad, but it fits this issue better. This patch allows anyone to be served an ad, but only those with the appropriate view permission can view the ad's node page. Since this is a significant change to the behavior of the module, it's targeted at the 3.x branch.

lrwebks’s picture

lrwebks commented
Issue summary: View changes
Status: Active » Closed (outdated)

Drupal 6 is EOL and no longer supported. Closing this as outdated for that reason. Thanks for your contribution!