Hello
It will be very good idea to change the "Views" term everywhere in the module to "Impressions". For English-speaking users, meaning of the text will not change, but it will be very helpful change for non-english sites and translators.
It's because word "Views" is reserved in 90% cases for Views module. And for example, in eastern-european languages, translation of "Views" in context of impressions and "Views" in context of displaying content is vary very much.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | ad_impressions_D6.patch | 15.91 KB | neochief |
| #3 | ad_impressions_D6.patch | 15.84 KB | neochief |
Comments
Comment #1
WildBill commentedI've worked in Internet advertising for a number of years (as my day-job), including at a major Internet ad agency. "Impressions" is definitely the preferred term, and the industry standard. "Views" is ambiguous.
Comment #2
neochief commentedPosting here patch for 6.x branch. It's only changes comments and strings with words "views" changed to "impressions" (of course, where it's needed). Internal variables and tables are not affected. I don't sure that they should be changed, because it can make havoc.
If this changes is okay, I can make another patch for 5.x
Comment #3
neochief commentedOoops, here's the patch:
Comment #4
neochief commentedAnother try, last patch failed patching process.
Comment #5
jeremy commentedLooks good. It will be important to backport this patch to 5.x-1.x-dev and 5.x-2.x-dev too so that things stay consistent. Thanks!
Comment #6
neochief commentedYes, I understand. I will prepare patches for 5.x soon.
Comment #7
jeremy commentedOkay, feel free to commit this patch when you're ready. The 5.x patches can follow later.
Comment #8
jeremy commentedBumping this issue -- I will try to apply today, though there have been a lot of changes to the code base that could make it difficult to apply.
Comment #9
jeremy commentedI see that this has already been committed to the 6.x branch. I found one other occurrence of "views" which I changed to "impressions".
I no longer think it's important to backport this to the 5.x branches. New feature development should happen in 6.x only, and we should only apply maintenance fixes to the 5.x branches. Closing issue. Thanks again!