After image uploading it has fid=0

Are you using the core drupal upload module? Is the upload module working in general?

Does the problem happen with the last stable release of the ad module?

What version of Drupal are you using? What OS? How did you track down the fid issue?

I've run into the same issue. After creating a new image ad, the fid attribute has the value 0 in ad_image table. The actual file entry is correctly created in the files table - by manually inserting the missing fid in ad_image the issue is solved (for this particular ad).

I'm using the core upload module (it works - verified with creation of non-ad content) and Drupal v. 5.3, Advertisement version is 5.x-1.4-1 (2008-Jan-13).

When this happens, if you go back and edit the ad (without making any changes, necessarily) and submit it, does the image then appear? In other words, does this only happen when the ad is first created?

Editing the ad (without making changes) does actually fix the problem - the correct fid is inserted into ad_image and the image is displayed correctly.

Any clue to what's going on?

Not offhand, except I think I've duplicated it. I'm off for the weekend, but hopefully I'll get time to look into this next week. That area of the ad_image module is, ugly, so no surprise there's a bug there...

Not offhand, except I think I've duplicated it. I'm off for the weekend, but hopefully I'll get time to look into this next week. That area of the ad_image module is, ugly, so no surprise there's a bug there...

It turned out being a very simple fix. Committed to the development branch.