In general you don't want ad nodes to show up in search results.

Also, if you go to the Search page then open "Advanced search":
- "Ad groups" should not be listed under "Only in the category(s)"
- "advertisement" checkbox should not appear under "Only of the type(s)"

The only exception to this would be if regular users can create ads, but in general this is not the case.

Comments

summit’s picture

summit commented

I disagree.
I think you should have an option whether or not you want ad-nodes to be shown in search results.

greetings,
Martijn

mariuss’s picture

mariuss commented

An option is fine, as long as there is a way to hide the ads from search.

jo1ene’s picture

jo1ene commented
Category: bug » feature
Priority: Critical » Normal

I require the feature to include ads in search. One slight problem I see is that the teaser that's shown in the search results includes things like the click history, since it's using "ad_status_display" to form the teaser. This stretches out the page on my site and doesn't strike me as helpful. If the teaser can be reformatted to just be the title and description (if one exisits), it would work really well for me.

Changing status to normal feature request.

jeremy’s picture

jeremy commented
Component: ad.module » ad module
Status: Active » Postponed

Postponed until someone comes along with a good patch.

Anonymous’s picture

Anonymous (not verified) commented
Priority: Normal » Critical

I'm finishing a website which uses Ad module and I just can't pass it to my customer because the Ad terms are in advanced search page. Is there some patch, or is this a dead end?

paulvantuyl’s picture

paulvantuyl commented

Hi, I am using this module http://drupal.org/project/search_block in order to block ads from being searchable. Works quite well.

jeremy’s picture

jeremy commented
Priority: Critical » Normal

Can someone document how to make this work with the search_block module? That sounds like a good solution to me...

jeremy’s picture

jeremy commented
Version: 5.x-1.3-2 » 6.x-2.x-dev
Assigned: Unassigned » jeremy
Status: Postponed » Active

I implemented something similar for the Jobtrack module. I may add this feature before the 6.x-2.0 release.

jeremy’s picture

jeremy commented
Status: Active » Fixed

Feature committed.

jeremy’s picture

jeremy commented

Whoops, needed to also remove the ad vocabulary and terms from the advanced search form. Committed.

jeremy’s picture

jeremy commented

With more thought, I've modified this a little. Advertisements will always show up for users with 'administer advertisements' or 'edit any advertisement' permissions. Fix committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.