Closed (fixed)
Project:
Advertisement
Version:
5.x-1.x-dev
Component:
ad_text.module
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Anonymous (not verified)
Created:
21 Mar 2007 at 12:55 UTC
Updated:
26 Feb 2019 at 20:59 UTC
Jump to comment: Most recent file
Comments
Comment #1
jeremy commentedIn general, the ad_text module needs some love to escape all special characters properly for use with JavaScript. For example, simply using a single quote in your text ad will cause it to not be displayed at all.
Bumping the priority to critical.
Comment #2
laghalt commentedGot the same problem - it seems like the module ignores that drupal uses utf-8 characters - interpret the utf-8 codes as iso-8859-1 and then translate it into html entities. Only place in drupal that this ocurs.
Comment #3
jeremy commentedCalls to htmlentities in both the ad_text and ad_image module have been fixed to use UTF-8 for proper international character support when displaying ads. This fix has been checked into both the 4.7.x and 5.x development trees and will be part of -beta9.
Comment #4
nomad@drupal.ru commentedIt's not working for me =)
I downloaded official release 5.x-1.0-1 (2007-May-04, http://drupal.org/project/ad).
I modifyed ad.install with the following:
Then found the following: using
show table status like 'ad%'we can see, that collation for all ad* tables is set toutf8_general_ci, then runningadminister -> modules, installing all ad* modules, modules create tables, trying to issue text-ad and looking at "?"-questions instead of text (I meant that we published text-ad and see only "?"). =)Then going back to mysql console and we can see, that for tables {ad_text}, {ad_image} and {ad_image_format} collation changed to latin1_swedish_1 again =)
Doing
alter table {*} convert to character set utf8and voila - everything seems to be ok now...Comment #5
jeremy commentedThanks nomad, I'm re-opening this issue to remind me to merge in this fix.
Comment #6
nomad@drupal.ru commentedThanks, Jeremy! I do really appreciate a bunch of work on this module you've done!
Comment #7
jeremy commentedFix committed to the 4.7.x and 5.x development branches.
Comment #8
(not verified) commented