#629296: Remove 'actions' trigger integration has caused an issue. By clicking the link shown here, we get a call to undefined function from system module. Basically its trying to call activity_record_form.

I would love to prevent this Action from showing up on this list. Basically, prevent it from being configured or form alter it so the configure link goes to our templating system.

http://img.skitch.com/20091117-gx8sficspi7nshhce88tw7dpc.jpg

Comments

sirkitree’s picture

sirkitree commented

/me had a feeling we were going to run into this if we took it out. I remember thinking we hsould not be showing these in the actions listing as well, but can't find where I made a comment about it. These are pulled directly from the actions table and only themed in a theme('table... call inside of system.module, so unless we want to take the entries out of the actions table altogether, I'm not sure what we can do here.

Maybe roll back that patch, and if a user clicks that link, the form they are presented with directs them to the activity template instead.

Scott Reynolds’s picture

Scott Reynolds commented
Priority: Normal » Critical

well how about this

The link there points to a url that renders a given form_id (activity_form). So lets line that form_id with the actual form that we want users to use.

And then we form alter the select form "Make an advance action available" (see screen shot) to remove Activity action from that select.

That prevents people from creating a an Activity action but allows people to configure that Activity action on the standard way.

This of course assumes that we can make the configure work. I have my doubts as we have this in the activity_form in activity.admin.inc

if ($arg1 == 'create') {
      // if we have a specific callback to create a new action, do so
      return _activity_settings_form_triggers($form_state);
    }
    else if ($arg1 == 'configure') {

So we would have to clean that up as well so it could work with the standard trigger configure and our template creation step.

Sorry for brainstorming post. but i think this is a Alpha blocker.

sirkitree’s picture

sirkitree commented

Yeah, this sounds like a good approach, but it may prove difficult because of the fact that the form is a multistep form.

If alter out the option from the select, then they only have one way to create these, which is preferable. And an entry will only show up after one is already created. So the link would only have to go to the last step of the form, just as the link on the Activity templates listing does.

Maybe we can alter the link instead of the logic?

Scott Reynolds’s picture

Scott Reynolds commented
Status: Active » Fixed

http://drupal.org/cvs?commit=371082

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.