Closed (fixed)
Project:
Activity
Version:
6.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Jul 2009 at 20:15 UTC
Updated:
16 Aug 2009 at 16:00 UTC
This is kind of a bunch of small admin UI cleanups that are kind of mixed together.
I was really annoyed that you could submit the form without selecting a module or operation. This makes those values required but for the red * to appear I had to move the title down from the fieldset, and at that point the fieldset wasn't really doing anything so I dropped it.
One other change was to load the proper names for the types so that a user role's name is used rather than the role id.
| Comment | File | Size | Author |
|---|---|---|---|
| activity_admin_ui_fixes.patch | 8.72 KB | drewish |
Comments
Comment #1
drewish commentedOh, $form_state should really be passed by reference. I was doing more with it earlier but pulled that out since it obscured the other changes.
Comment #2
sirkitree commentedAll looks good, thank you! Committed.