On /user/[uid]/activity/settings page I was select one checkbox 'don't record my activity when new comment posted' and press 'Save' button. Now I see that this checkbox is selected.
Then I unselect 'don't record my activity when new comment posted' and press 'Save' button again and I don't see any changes - the checkbox is still selected!
Then I try to select some one else, for example, 'don't record my activity when comment is updated' and press 'Save' - nothings happens! Now there is always one selected item - the first item.
Tested on clear install Drupal 6.13 + Token and Trigger modules. Server configuration: FreeBSD + Apache + PHP 5.2.8 (cgi) + mysql 5.1.29-rc. Tested also on Windows with PHP 5.2.4 and mysql 5.0.45.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | activity_517714.patch | 936 bytes | drewish |
| #2 | Picture 2.png | 59.06 KB | drewish |
| #2 | activity_user_ignore_517714.patch | 2.7 KB | drewish |
Comments
Comment #1
drewish commentedhumm... i just tested it and got the opposite behavior i can't get any check boxes to stick.
Comment #2
drewish commentedhere's a patch to clean up the saving. i think using the checkboxes was really wonky. I went with radios because it was easier to make it clear what you were choosing. It also made for a lot less code.
Attaching a screen shot previewing it. The first item is missing a title because I'd removed it from hook_triggers_hook_info() but not my database.
Comment #3
drewish commentedmarked #484540: Can’t make any changes on activity page at /user/[uid]/activity/settings as a duplicate
Comment #4
dicreat commentedPatch work for me, now I can save my personal settings on activity privacy settings page. I'm turning off logging of some actions, but in activity log I still see this action's messages.
Comment #5
sirkitree commentedI like it! Thanks!
Comment #6
dicreat commentedThere is no sense in these settings if they don't work! All users’ actions still logging, even if they disabled at activity privacy setting page.
Comment #7
drewish commenteddicreat, a proper bug report would be much more helpful than throwing a tantrum. the settings at least save now, small steps. either re-open this or create a new issue.
Comment #8
drewish commentedSmall follow up to help set the correct default value the first time the user views the form. Currently there's no value set by default.
Comment #9
sirkitree commentedAh, thank you. That works much better. Committed.