Just a really minor theming issue on the form. The label on the active tag edit doesn't have the proper id in the "for" attribute. I've attached a patch for it.

CommentFileSizeAuthor
active_tags_label.patch804 byteshadsie

Comments

samkat12’s picture

samkat12 commented
Title: Minor theming issue » Required term field not highlighed whe using Active Tags if is required and not filled in by user

when i use Active Tags, if feild (term) is required and user does not fill in the tags, the active tag does npot highlight that the field is requred. therefore end user does not know which field is he/she has not filled in.

dragonwize’s picture

dragonwize commented
Status: Needs review » Closed (duplicate)

Duplicate of #639214: Required input fileds are not wrapped in error-tags

hadsie’s picture

hadsie commented
Status: Closed (duplicate) » Active

I've just upgraded to the latest dev version (jan 17th) that has this fix in it. Though it doesn't appear to fix the issue I mentioned here.

In your fix you have:

    '<label for="' + context + '-edit-tags">' + wrapper.find('label').html() + '</label>' +

However, the actual field is:

    '<input type="text" class="' + error + 'tag-entry form-autocomplete" size="30" id="active-tag-edit0' + vid + '" />' +

So the "for" doesn't match the id on the field. This is the only change the attached patch makes.

I've re-opened this ticket instead of #639214: Required input fileds are not wrapped in error-tags because I'm not sure if it's actually the same problem or not. Basically when I "click" the label, the textfield should become active for entry.

dragonwize’s picture

dragonwize commented

I am confused is this issue about "Required term field not highlighed whe using Active Tags if is required and not filled in by user"?

Or is it about the for attribute?

hadsie’s picture

hadsie commented

I also don't understand the title... all I'm talking about is the "for" attribute not being set correctly. I think that title refers exactly to the duplicate issue that's already fixed.

dragonwize’s picture

dragonwize commented
Title: Required term field not highlighed whe using Active Tags if is required and not filled in by user » Label for attribute not matching input id
Status: Active » Fixed

Thanks. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.