Connection override for solr port broken after 8.11 [#2883802]

After the change introduced in https://www.drupal.org/node/2877463 I am no longer able to use the connection_override feature to use a local solr instance running on any port other than 80 or 443 as now the port is hard coded and does not respect what is set in the override.

Comment	File	Size	Author
#2	acquia_connector-port_override_broken-2883802-2.patch	1.51 KB	generalredneck
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

5 June 2017 at 10:58

ericgsmith created an issue. See original summary.

Comment #2

generalredneck

him/his

English

Texas, USA 🇺🇸

CreditAttribution: generalredneck commented 18 June 2017 at 19:55

Version:	8.x-1.11	» 8.x-1.x-dev
Status:	Active	» Needs review

File	Size
acquia_connector-port_override_broken-2883802-2.patch	1.51 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 Patch Failed to Apply

This is still the case in 8.x-1.x-dev. Here's a patch. It looks like there are some assumptions made around https and http that caused the ports to be hard coded. I made the code make a default assumption based on schema when gathering the default Configuration and just passed that along.

Comment #3

18 June 2017 at 19:59

Status:

Needs review

» Needs work

The last submitted patch, 2: acquia_connector-port_override_broken-2883802-2.patch, failed testing. View results

Comment #4

ericgsmith CreditAttribution: ericgsmith at Cameron and Wilding Ltd commented 30 June 2017 at 10:15

Thanks Allan,

Works well for me locally but haven't tested yet on Acquia yet but will update when I have.

Would be good if somebody from Acquia that had more info on https://www.drupal.org/node/2877463 could review to ensure whatever ways causing that issue isn't re-introduced with the patch - but from looking just at the code it looks good to me.