After the change introduced in https://www.drupal.org/node/2877463 I am no longer able to use the connection_override feature to use a local solr instance running on any port other than 80 or 443 as now the port is hard coded and does not respect what is set in the override.

CommentFileSizeAuthor
#2 acquia_connector-port_override_broken-2883802-2.patch1.51 KBgeneralredneck

Comments

ericgsmith created an issue. See original summary.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Version: 8.x-1.11 » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new acquia_connector-port_override_broken-2883802-2.patch1.51 KB

This is still the case in 8.x-1.x-dev. Here's a patch. It looks like there are some assumptions made around https and http that caused the ports to be hard coded. I made the code make a default assumption based on schema when gathering the default Configuration and just passed that along.

Status: Needs review » Needs work

The last submitted patch, 2: acquia_connector-port_override_broken-2883802-2.patch, failed testing. View results

ericgsmith’s picture

ericgsmith commented

Thanks Allan,

Works well for me locally but haven't tested yet on Acquia yet but will update when I have.

Would be good if somebody from Acquia that had more info on https://www.drupal.org/node/2877463 could review to ensure whatever ways causing that issue isn't re-introduced with the patch - but from looking just at the code it looks good to me.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Closed (outdated)