Hey chriz - actually it was from the review http://drupal.org/node/1966828#comment-7282808 Sam had some concerns about the list being presented not matching anything at 2 or less characters.
I think the improvement sam suggested is the same as the one i was trying to ask about. Unless i have misunderstood.
When i type 1 character i dont get any autosuggest box. - this is fine.
When i type 2 characters, the autosuggest box drops down, but it starts at A. it doesn't show me any results based off what i have typed. - no filtering.
When i type 3 characters, i get useful autosuggestions. - this is what i would expect.
If i change the minChars in jquery.autocomplete.js at line 385 it keeps the same behaviour, but it just changes the number of characters i need to type.
I thoroughly looked through that part of the script and I think I understand where this is coming from in terms of a user perspective. Or at least my alteration.
So I changed the min threshold to 0 char which means the list actually properly starts filtering at 2 characters. The list still reveals the full list at 1 char and I think this make sense as a user because once I start typing at least I can see what my options are.
Comments
Comment #1
jerrylow commentedHey chriz - actually it was from the review http://drupal.org/node/1966828#comment-7282808 Sam had some concerns about the list being presented not matching anything at 2 or less characters.
Currently set in jquery.autocomplete.js:385
Comment #2
chriz001 commentedHi Jerry,
I think the improvement sam suggested is the same as the one i was trying to ask about. Unless i have misunderstood.
When i type 1 character i dont get any autosuggest box. - this is fine.
When i type 2 characters, the autosuggest box drops down, but it starts at A. it doesn't show me any results based off what i have typed. - no filtering.
When i type 3 characters, i get useful autosuggestions. - this is what i would expect.
If i change the minChars in jquery.autocomplete.js at line 385 it keeps the same behaviour, but it just changes the number of characters i need to type.
Thanks Jerry.
Nice work by the way :)
Comment #3
jerrylow commentedThanks, the autocomplete script was written by Jarn - another author. I'll dig into the script to see if I can make some adjustments.
Comment #4
chriz001 commentedsounds good :)
thankyou.
Comment #5
jerrylow commentedHey Chriz,
I thoroughly looked through that part of the script and I think I understand where this is coming from in terms of a user perspective. Or at least my alteration.
So I changed the min threshold to 0 char which means the list actually properly starts filtering at 2 characters. The list still reveals the full list at 1 char and I think this make sense as a user because once I start typing at least I can see what my options are.
Hope that makes sense.