Closed (fixed)
Project:
Faux strongarm
Component:
Miscellaneous
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
26 Jul 2011 at 04:12 UTC
Updated:
27 Sep 2011 at 05:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
das-peter commentedHi there,
In lack of an existing patch I created one. It's build against the latest 7.x-2.x-dev version of Strongarm.
I also made some small additional changes:
theme("table_select_header_cell")- it's deprecated for D7.variable_features_revert()- replaced$vars['name']->valueby$vars[$name]->value.Comment #2
Pisco commentedFixed a typo in das-peter's patch and posted it to #1094598: Performance issues from strongarm_init().
Comment #3
das-peter commentedThank you both for keeping this alive :)
@Pisco: As promised I digged into the installation issue. I think I got it - at least it works out on all our stages.
The patch is again for 7.x-2.x-dev and includes:
To make it easier to update the patch for 6.x I've attached the diff between the both patches.
Changes:
!=to!==needed to ensure arrays are really equal.variable_features_rebuildto thisif (isset($vars[$name]->in_code_only) || (drupal_installation_attempted() && $vars[$name]->export_type & EXPORT_IN_CODE)) {This allows that the variables are set during the installation.
(Maybe we don't event need
isset($default->in_code_only)now - but I'm not sure about that.)Comment #4
catchI'm going to mark this issue fixed since #1094598: Performance issues from strongarm_init() has a patch.