Drupal 7 porting

I'm also interested in payment options for Drupal 7. If there is any plan for Pay, please let us know.

I'm interested in contributing (with patches and testing) to the porting to D7 effort.

Hi All,

Porting Pay to Drupal 7 is very high on our list of priorities right now and are working to get the time to do this slotted into our schedule. We've started upgrading some of the periphery modules such as Postal.

Porting the Payment API to D7 should be relatively pain free, if anyone wants to take a crack at it and post a patch we certainly wouldn't turn them down, otherwise if you'd like to support the effort in other ways that's also appreciated! Either way we'll keep folks apprised!

+1

+1

@jerdavis: any update?

Hey folks,

We're working a lot on Pay right now, rolling new features and big bux fixes out every day. This is our current priority. After all of this shakes out, we'll be thinking about an upgrade.

Thanks!

@Allie:

I noticed the development! What do you project as a timeline for upcoming development?

We are looking at using Pay in an upcoming D7 project, so a port is of great interest to us, and we may be able to assist with it. What do you see as the challenges in doing a port?

Any one interested in getting this done by the end of next week for a bounty?

Up!

I might take a crack at it this week. Really need a D7 version very soon...

Subscrizzle

Subscribing.

Subscribing. Would possibly also donate funding to move this along. Pay + Webform Pay = very good solution for many payment based applications.

Ran out of time last week and decided to use lm_paypal instead. I will probably need this for another project though so I might try porting it in the near future.

Hey everyone,

This is definitely on our radar. Because this work is currently not funded by anyone, we're scheduling this around our client work schedule. (we all gotta eat, right?) If this project were to become funded by someone, we could provide more definitive information on when a D7 version might be available and I'll update here.

It's likely that the upgrade will be somewhat invasive from an API standpoint, since I would like to get the class and method naming conventions more in line with D7's coding standards. IT would also be nice if payment forms were entities. This will mean coordination with other backend and form providing modules. Beyond that, I don't expect that I'll make many changes.

subscribe

How about a quick port of the D6 version to get it working in D7 (so other modules like Webform Pay can move up to D7), then a 2.x branch for the entity conversions of Pay? What would the timeline of the first one be?

Here’s the work that I’ve done so far. Ran the code through Coder Upgrade and started cleaning it up. Still tons of work to do and don’t think that I’ll have any more time to put towards this for a while...

@allie, I tried contacting you a couple of weeks ago re a bounty for this. Any interest? Alternatively we could put a dev on this.

Hi Allie, should I bother expanding on the work I posted in #19, or do you have someone working on a rewrite of the module?

I was going to rewrite it with some of the ideas Allie had, but in the end the client didn't have enough budget for that :( So I ended up fixing up the d7 port some more. This one gets rid of a lot more errors but is probably not finished - there are some todos left in the code btw, especially in areas where I wasn't clear.

The next step for me is to port the pay_realex payment gateway module and start testing some actual transactions rather than just the UI.

I'll be actively working on this over the next couple of days.

@stella can you post a patch for the work you've done? DId you do any refactoring or just a straight d7 port?

Updated version, working quite well for me with my D7 ports of 'pay_realex' payment gateway and 'webform_pay' (see relevant issue queues if interested).

This takes the coder_upgrade output and fixes all the problems it finds. It's too tricky at this stage for me to create a patch file, sorry. There's still a few todos in the code, but got rid of most of them, but that's probably a place to start if you want to clean it up some more.

Actually I had the 6.x-1.1 version in a different git repository, so was able to overwrite that and generate a patch file that way. I'm not sure how useful it is as coder_upgrade changes the coding style throughout and so there are way more changes than a straight port warrants but there's not much I can do about that.

subscribe

subscribe

Stella's version worked for me, although I probably didn't touch on many parts of the functionality. I used it with a Authorize.Net dev account and a D7 port for that (#1281366: Authorize.Net D7 port) as well as the webform pay D7 port to provide the form (#1239466: Drupal 7 Port?).

I've separated the formatting coder upgrade changes in a patch, then the functionality Stella provided with a few additions. One thing I had to change was a function call in the actions/trigger integration - it would be great if someone who uses this to confirm it's still working for them.

// pay.trigger.inc, around line 60: _trigger_get_hook_aids() doesn't exist in D7, use trigger_get_assigned_actions() instead.

/**
 * Helper function to call 'actions_do'
 */
function pay_actions_do($hook, &$object) {
  if (module_exists('trigger')) {
    $context = array();
    foreach (trigger_get_assigned_actions('pay') as $aid => $action_info) {
      if ($aid) {
        actions_do($aid, $object, $context);
      }
    }
  }
}

So apply d7_formatting-998736-28.patch first, then d7_formatting-998736-28.patch.

Subscribe - I have some comments coming soon...

I've branched Webform Pay for 7.x-1.x over in #1239466: Drupal 7 Port?. Sorry I deleted comment #30 above this one, as I accidentally posted #1239466-8: Drupal 7 Port? in this queue instead of the Webform Pay one.

+1

I have committed the patches from NicholasH and Stella, and I have opened up a Drupal 7 branch.

I'm marking this issue as 'fixed'. Please file new tickets with specific bug or feature requests on Drupal 7.

Big thanks on those patches, by the way!