Patches in #290421: pathauto patch to provide localized and entity translated taxonomy through i18n have pointed out a few bugs in our bulk generation queries in 6.x-1.x.

CommentFileSizeAuthor
#2 991986-pathauto-fix-bulk-queries.patch10.51 KBDave Reid
#1 991986-pathauto-fix-bulk-queries.patch10.21 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review
FileSize
991986-pathauto-fix-bulk-queries.patch10.21 KB

Tested this manually, but I'll let it run against the bot too.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
991986-pathauto-fix-bulk-queries.patch10.51 KB

Hrm, we don't have to load in taxonomy terms ourselves either. taxonomy_nodeapi('load') does that for us...

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

I tested the SimpleTests manually and did bulk generation on my local dev site and it worked great. So I committed #2 to CVS.
http://drupal.org/cvs?commit=461016

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

This is against 6.x-2.x, right?

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

No, 6.x-2.x uses the batch api and radically different bulk generation code. This is for 6.x-1.x only.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Version: 6.x-1.x-dev » 5.x-2.x-dev
Status: Fixed » Patch (to be ported)

Does need to be backported to 5.x-2.x though..

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

ok, thanx Dave ;)

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Version: 5.x-2.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Fixed

I'm pretty sure that 5.x-2.x is no longer maintained.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.