Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Make group labels localizable, please
Comment | File | Size | Author |
---|---|---|---|
#5 | 989602-group-label.patch | 1.39 KB | andypost |
#4 | 989602-group-label.patch | 1.44 KB | andypost |
Comments
Comment #1
Stalski CreditAttribution: Stalski commentedok, sorry for that ;)
fixed and committed
Comment #2
andypostThere's security issue with this fix http://drupal.org/cvs?commit=468534
User input printed without validation!!!
Comment #3
nils.destoop CreditAttribution: nils.destoop commented$group->label now goes to check_plain.
Comment #4
andypostSuppose this should be check_plain(t($group->label)) and another missed place with direct output
Comment #5
andypostUsing %group is enough for check_plain()
Comment #6
nils.destoop CreditAttribution: nils.destoop commentedPatch applied
Comment #7
andypostThis hunk is lost before commit!!!
Also I'd like to point that core does not translate a strings that are user defined - this task for l18n module
Powered by Dreditor.
Comment #8
nils.destoop CreditAttribution: nils.destoop commentedSecond line of patch also committed.
Thx for the Dreditor link. Didn't know that one. Very usefull for small patches.
Hope Chrome support works fast. :)
Comment #9
Stalski CreditAttribution: Stalski commentedNice job ;)
Comment #10
carajito CreditAttribution: carajito commentedThis will be incorporated into the next update?
Comment #11
nils.destoop CreditAttribution: nils.destoop commentedThis is on dev. So it will idd be incorporated into the next update.
Comment #12
carajito CreditAttribution: carajito commentedan estimated date???
Comment #13
carajito CreditAttribution: carajito commentedIt is not on the 7.x - 2.x-dev yet
Comment #14
adelka CreditAttribution: adelka commentedsubscribe - solution for 7?