ImageCache iteratively applies operations to an image (actually, in most cases, these queue the operations for a server-side toolkit like GD) but loses changes to the image array between operation invocations because _imagecache_apply_action() doesn't use pass-by-reference. External services like Smush.it (refer http://drupal.org/project/imagecache_smushit ) need to alter the image array in order to affect downstream operations.

This change could have implications for ImageCache actions that alter the image array without the changes persisting.

CommentFileSizeAuthor
imagecache_apply_action.patch527 bytesjonathan_hunt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sreynen’s picture

sreynen CreditAttribution: sreynen commented
Status: Active » Reviewed & tested by the community

Single character patch to opens up more use cases? Easy RTBC.

YK85’s picture

YK85 CreditAttribution: YK85 commented

subscribing

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Reviewed & tested by the community » Fixed

Committed to 6.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.