Add hook_node_info_alter

I've tried various ways of applying one or two patches to test this, and I'm not getting all the needed changes applied. Either there is a broken patch, or I need simpler instructions :)

I didn't like the documentation for features_get_alter_state() so I took a stab at rewriting it. Would have made a patch, but

/**
 * Gets the mode for alter hooks for a component.
 *
 * Alter hooks may be run per component instance or not at all, depending
 * on hook_features_api() implementation.
 *
 * @param $component
 *  (default: NULL) Specify a given component. If not specified, will return
 *  alter state for all components.
 * @param $reset
 *  (default: FALSE) Whether or not to rebuild the alter states from code.
 *
 * @return
 *  Associative array, maps the use of alter states against each component
 *  definition hook. Possible states include:
 *  - single: Run per single component.
 *  - inside_hook: An alter hook invocation is placed inside the default hook.
 *  - none: Do not alter (or alter is take care of after all components are loaded).
 */

Here's a rebuilt patch that applies cleanly to the 6.x-1.1 release and current dev (there were a few small changes to one of the functions).

I like most of the ideas in #6, but I'm wondering why the Node exportable needs the new inline alter added to it. Doesn't the existing features_get_default call drupal_alter for the default_hook already? Why does Node need to be different/special?

Confused. Still seems like features_get_default is already calling drupal_alter('node_info', ... and thus the "inline" drupal_alter call is not needed, so I'm not sure you answered my question.

You could replace it with a wrapper function that hits a statically cached value. That would avoid bad global mojo and perhaps simplify debugging.

+++ b/includes/features.node.inc
@@ -86,6 +87,10 @@ function node_features_export_render($module, $data, $export = NULL) {
+ $output[] = ' global $features_alter;'; ¶

whitespace at end of line

Also failed to apply to latest 7.x-1.x-dev version.

Otherwise I think the approach is good.

The last patches weren't applying against the 6.x-1.x-dev of Feb 22/2012 so I re-rolled one.

I didn't see an /includes/features.image.inc file so I ignored that bit.

I'm still not happy with the way the alter hook for node is implemented. The use of the global features_alter variable just seems kludgy. For the sake of trying to get the really important piece of this patch into Features soon, here is a reduced patch for the 7.x-1.x-dev version that removes the global and the node alter and just contains the core code to add the new alter hook information to the api.

Committed f7447af

Also, the node stuff should go to a new issue if we can figure out a better way.

Merged f7447af to 6.x-1.x & patched for review.

I'm looking to export a forum setup to a feature.

I've patched Features 6.x-1.x-dev with #23 on #1390848: Centralize the call to hook_features_api() and #25 here, but I'm not getting 'Forum topic' in the Content types.

Is there a further step I should be taking? Or am I viewing this the wrong way, or simply barking up the wrong tree? Thanks for any advice.

Bump for testbot.

Thanks!

I had a content type named "Show" and needed to swap the t()function for adding some context so I can avoid the translation of the content type name. Works like expected. Here is my hook as an example for a potential use case.

function MYMODULENAME_node_info_alter(&$info) {
  if (key($info) == 'show') {
    $info['show']['name'] = t('Show', array(), array('context' => 'Content Type Name'));
  }
}