There were some missing t()s we found as we were going through. This patch adds them back in. It also removes the t() around 'Drupal' in aggregator module's site_name variable get, since there is nowhere else in core where that is translated.

CommentFileSizeAuthor
#4 t_4.patch7.1 KBRobRoy
#3 fix-ts_1.patch7.09 KBwebchick
#2 fix-ts_0.patch7.09 KBwebchick
fix-ts.patch11.23 KBwebchick

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

( ! ) Parse error: syntax error, unexpected ';' in /home/drumm/drupal/drupal/C-HEAD/includes/theme.inc on line 1021

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: String freeze clean-up: fix some t()s » String freeze: add some t()s
Status: Needs work » Needs review
StatusFileSize
new fix-ts_0.patch7.09 KB

Well that's no good, is it? ;)

Here's a re-roll. This does not include a couple of the changes (aggregator and drupal.module, I think), which are/were covered by other patches.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new fix-ts_1.patch7.09 KB

Just a re-roll to get rid of offsets.

RobRoy’s picture

RobRoy commented
StatusFileSize
new t_4.patch7.1 KB

Took the spaces out of t() as we'll always want those out of there so someone doesn't accidentally remove them then have text smushed together? Also, put double quotes around the string with the single quote as that's the direction we're going now right? Super minor changes.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Yeah, Neil wanted each different change in a separate patch, but this one is pretty small and easy to review for the other minor changes you included, so I think it's ok. Looked it over. Looks good. Tentatively marking RTBC.

RobRoy’s picture

RobRoy commented

Yeah, I was thinking that I was mixing my meat and dairy together. Thanks webchick!

dries’s picture

dries commented
Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)