It would save half the KB if this module used the minified version of fullcalendar.js. I have one site where, since I use a private filesystem, I can't aggregate or minify JS files, so it would be really nice if I could use the minified version...

Also, seeing that most people probably don't have minified JS on their sites, simply using the minified version of the JS file will save a lot of bandwidth in the long run.

CommentFileSizeAuthor
#9 fullcalendar-980810-9.patch3.23 KBtim.plunkett
#5 fullcalendar-980810-6.patch3.11 KBtim.plunkett

Comments

jwhat’s picture

jwhat commented

I agree that we should use the minified file. We just need to wait until #906112: handle drag and drop: creating events, rescheduling events is complete before we can make more structural changes.

Also, I just opened up a ticket to upgrade the fullcalendar library #980886: Require Libraries API since its been awhile. So that should probably be resolved before we tackle this.

geerlingguy’s picture

geerlingguy commented

Is it possible to use the Libraries API for the fullcalendar library, and just require the user to download the latest version and put it in sites/all/libraries? That may be better moving forward, and would allow this module to not have to always stay in sync with the fullcalendar.js releases (third party code and all that).

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

+1 for putting the file in /sites/all/libraries and/or full Libraries API support.

Also, it might be beneficial to either a) detect whether the normal or minified version is installed, or provide a way of controlling it? The option would be useful for when using the Javascript_Aggregator module, to give more control over what is minified.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Any Reason for Not Using fullcalendar.min.js? » Option to use fullcalendar.min.js
Version: 6.x-1.2-beta5 » 6.x-1.x-dev
Status: Active » Postponed

Postponing on #980886: Require Libraries API.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs review
StatusFileSize
new fullcalendar-980810-6.patch3.11 KB

This still depends #980886: Require Libraries API.

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Reviewed & tested by the community

When applied in tandem with #980886: Require Libraries API, this patch works beautifully, and I can confirm the .min.js file was used. Very nice!

Also, you need to configure the fullcalendar module after applying this patch, at admin/settings/fullcalendar. This way the location of the fullcalendar.js or fullcalendar.min.js file is set correctly.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Patch (to be ported)

http://drupal.org/cvs?commit=471722
Now for D7!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new fullcalendar-980810-9.patch3.23 KB

Once again, depends on #980886: Require Libraries API.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Works :), (after you change the admin path) tim told me he is going to fix this before pushing it.

==> RTBC

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

http://drupal.org/cvs?commit=485158

aspilicious’s picture

aspilicious commented
Status: Fixed » Closed (fixed)

Cleanup of the issue queue!