Update the data in views and figure out what graphics to use to make the insertion and deletions look like github (see screenshot below).

http://img.skitch.com/20101122-rr2j6ts4xmn75e4dgjy11ctci.png

Files: 
CommentFileSizeAuthor
#9 dg-diffstat-v3.png272 bytessarah_p
#5 versioncontrol_views_diffstat.patch6.51 KBmikey_p
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch versioncontrol_views_diffstat_0.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

sarah_p’s picture

Title: Insert and Delete graphics » Insert and Delete graphics on commitlog
marvil07’s picture

sarah_p’s picture

Issue tags: +git sprint 7

The meta issue for this is #970200: Create shippable commit views

sarah_p’s picture

Assigned: Unassigned » sarah_p
mikey_p’s picture

Assigned: sarah_p » Unassigned
Status: Active » Needs review
Issue tags: +git sprint 8
FileSize
6.51 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch versioncontrol_views_diffstat_0.patch. Unable to apply patch. See the log in the details link for more information. View

This patch adds a new handler that tries to perform an accurate diffstat for changes to a file, and format it into an odd number of placeholders to indicate either additions or subtractions, or no-op, i.e. ++-- or ++++- or +----

Note: Originally, I posted this over at #1011726: Add a diffstat style indicator for lines added/removed before finding this issue.

sdboyer’s picture

Status: Needs review » Needs work

The diffstat algorithm & field look good. I've committed those; marking needs work now because we still need some theming ju-ju on top of the baseline provided by the field.

Here's a screenie of how this looks, for browsing users' viewing pleasure...

mikey_p’s picture

Assigned: Unassigned » mikey_p
mikey_p’s picture

Status: Needs work » Fixed

Committed.

sarah_p’s picture

FileSize
272 bytes

Here is the graphic for future reference.

sdboyer’s picture

Committed the latest image. Was exhausted and forgot to give you credit in the commit message, sorry.

Status: Fixed » Closed (fixed)
Issue tags: -git sprint 7, -git sprint 8

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit dc843dc on repository-families, drush-vc-sync-unlock by sdboyer:
    Issue #979066 by mikey_p, sarah_p: Add a visual diffstat views field.
    
    
  • Commit e97e56f on repository-families, drush-vc-sync-unlock by mikey_p:
    #979066 by sarah_p, mikey_p: add icons for diffstat
    
    

  • Commit dc843dc on repository-families by sdboyer:
    Issue #979066 by mikey_p, sarah_p: Add a visual diffstat views field.
    
    
  • Commit e97e56f on repository-families by mikey_p:
    #979066 by sarah_p, mikey_p: add icons for diffstat