Update the data in views and figure out what graphics to use to make the insertion and deletions look like github (see screenshot below).

http://img.skitch.com/20101122-rr2j6ts4xmn75e4dgjy11ctci.png

CommentFileSizeAuthor
#9 dg-diffstat-v3.png272 bytessarah_p
#5 versioncontrol_views_diffstat.patch6.51 KBmikey_p

Comments

sarah_p’s picture

sarah_p commented
Title: Insert and Delete graphics » Insert and Delete graphics on commitlog
marvil07’s picture

marvil07 commented

probably blocked until #976130: Add number of lines added/removed to commitlog views gets in

sarah_p’s picture

sarah_p commented
Issue tags: +git sprint 7

The meta issue for this is #970200: Create shippable commit views

sarah_p’s picture

sarah_p commented
Assigned: Unassigned » sarah_p
mikey_p’s picture

mikey_p commented
Assigned: sarah_p » Unassigned
Status: Active » Needs review
Issue tags: +git sprint 8
StatusFileSize
new versioncontrol_views_diffstat.patch6.51 KB

This patch adds a new handler that tries to perform an accurate diffstat for changes to a file, and format it into an odd number of placeholders to indicate either additions or subtractions, or no-op, i.e. ++-- or ++++- or +----

Note: Originally, I posted this over at #1011726: Add a diffstat style indicator for lines added/removed before finding this issue.

sdboyer’s picture

sdboyer commented
Status: Needs review » Needs work

The diffstat algorithm & field look good. I've committed those; marking needs work now because we still need some theming ju-ju on top of the baseline provided by the field.

Here's a screenie of how this looks, for browsing users' viewing pleasure...

Only local images are allowed.

mikey_p’s picture

mikey_p commented
Assigned: Unassigned » mikey_p
mikey_p’s picture

mikey_p commented
Status: Needs work » Fixed

Committed.

sarah_p’s picture

sarah_p commented
StatusFileSize
new dg-diffstat-v3.png272 bytes

Here is the graphic for future reference.

sdboyer’s picture

sdboyer commented

Committed the latest image. Was exhausted and forgot to give you credit in the commit message, sorry.

Status: Fixed » Closed (fixed)
Issue tags: -git sprint 7, -git sprint 8

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git sprint 7, +git sprint 8

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit dc843dc on repository-families, drush-vc-sync-unlock by sdboyer: 
    Issue #979066 by mikey_p, sarah_p: Add a visual diffstat views field.
  • Commit e97e56f on repository-families, drush-vc-sync-unlock by mikey_p:
    #979066 by sarah_p, mikey_p: add icons for diffstat

  • Commit dc843dc on repository-families by sdboyer: 
    Issue #979066 by mikey_p, sarah_p: Add a visual diffstat views field.
  • Commit e97e56f on repository-families by mikey_p:
    #979066 by sarah_p, mikey_p: add icons for diffstat