Now that Gerhard has begun delegating CVS administration on d.o it seems that we could do with an extra status "Pending response".

Currently, when I looked at the list of pending applications, it's not possible to know which have been replied to for additional info from the applicant. Monitoring the cvs-apps list seems to be the only way to know another admin is dealing with an application.

This simple patch adds the field "Pending response" that shows cvs admins are waiting from feedback and therefore not to start feedback cycle with the applicant.

This is the first of maybe a few features that we hope to provide now that d.o has multiple CVS admins.

CommentFileSizeAuthor
cvs.module_r1.106.2.21_p14.96 KBAjK

Comments

gerhard killesreiter’s picture

gerhard killesreiter commented
Status: Needs review » Fixed

applied

dww’s picture

dww
we/he/they
commented

killes: you committed this to HEAD. d.o is running DRUPAL-4-7--2 branch. are you just planning to wait until we port cvs.module to 5.0 before seeing this improvement, are you planning to backport to DRUPAL-4-7--2, or just confused? ;)

a) please *only* commit d.o modifications to DRUPAL-4-7--2 branch. we're not running HEAD yet, and it's not clear when we will be...

b) i'm periodically merging all changes from DRUPAL-4-7--2 into HEAD (via a single CVS command) whenever i make another tag along DRUPAL-4-7--2 branch (e.g. if i do a 4.7.x-2.1 release). so, no need to commit to both branches.

thanks,
-derek

killes@www.drop.org’s picture

killes@www.drop.org commented

I committed this to HEAD and 4.7-HEAD and switched drupal.org to run from 4.7-HEAD again. This apparently broke something...

Can we reach an agreement that d.o runs on 4.7-HEAD?

dww’s picture

dww
we/he/they
commented

to reiterate: d.o runs DRUPAL-4-7--2 branch. that's where all the new release system code lives.

  1. only commit to DRUPAL-4-7--2 if you want it on d.o
  2. i'll make sure it gets into HEAD at the next merge
  3. committing to N branches is a waste of time that can finally be avoided with proper CVS merges (i'll take care of the merges when/where needed)
  4. if you make bug fixes to DRUAPL-4-7--2 branch, i'll back-port them to DRUPAL-4-7 if appropriate (for the pre-release-system version of everything, the 4.7.x-1.* series that many external sites are still running) since i know you don't care about the external users of project + cvs, only d.o. that's fine.

thanks,
-derek

p.s. "4.7-HEAD" makes no sense in CVS terminology. you can say "DRUPAL-4-7 branch" if you mean the end of that branch.
"HEAD" means HEAD: http://drupal.org/handbook/cvs/introduction#HEAD

dww’s picture

dww
we/he/they
commented
Version: 4.7.x-1.x-dev » 4.7.x-2.x-dev
Status: Fixed » Needs work

this patch was against DRUPAL-4-7. zen made a ton of huge changes in http://drupal.org/node/93089 and http://drupal.org/node/97031 which only went into DRUPAL-4-7--2 branch (what we use on d.o).

this patch doesn't apply to DRUPAL-4-7--2, and i'm not porting it.
please try again, set to needs review, and i'll look at it.

thanks,
-derek

AjK’s picture

AjK commented
Status: Needs work » Closed (won't fix)

Dww, thanks for that. Ok, my second patch basically redoes this patch. So this patch is duff.

What's more, that means my second patch is against the wrong branch too. So, I'll make this "won't fix" and redo my other patch.

cheers,
--AjK

dww’s picture

dww
we/he/they
commented

ok, i just undid the revision that added this patch to HEAD. i guess i'll have to sort out the damage in the DRUPAL-4-7 branch... ;)

dww’s picture

dww
we/he/they
commented

also backed out the patch from DRUPAL-4-7 branch. this issue is hereby dead. ;)