If you assign multiple parents to a term for the first time in a given vocabulary you are warned that drag and drop functionality will be disabled. In fact, however, after agreeing to proceed, you can still drag and drop the terms to change their parents and weight, however, the save changes button is no long visible.

This is a bit confusing. I'd say that drag and drop needs to be fully disabled when there are multiple parents assigned to one more terms. I believe this was the case at one point but no longer is.

I tested with a D7 head build from Nov 10th.

CommentFileSizeAuthor
#5 969194-taxonomy-drag-drop-5.patch2.2 KBmr.baileys
#2 969194-taxonomy-drag-drop-2.patch2.54 KBmr.baileys

Comments

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

Marked #1090586: taxonomy drag & drop not properly disabled for multiple parent vocabs as duplicate.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Active » Needs review
StatusFileSize
new 969194-taxonomy-drag-drop-2.patch2.54 KB

Looks like this was caused by adding a weight column in #846524: Terms cannot be manually reordered by weight. for accessibility reasons, since the patch that got committed there enables tabledrag behavior regardless of the taxonomy hierarchy type.

Patch attached that:

  • Moves the drupal_add_tabledrag for weight so it is only enabled for flat lists and single-parent hierarchies.
  • Only shows the weight column and header for flat lists and single-parent hierarchies (when javascript is disabled).
stockliasteroid’s picture

stockliasteroid commented
Status: Needs review » Reviewed & tested by the community

I'd like this to get committed... This was causing major headaches for a client that keeps screwing up the hierarchy, but the fact that it still "sort of" works is super confusing. This makes is a boolean condition, you can either reorder or you can't.

Tried this on that site and it worked a treat.

megaphonejon’s picture

megaphonejon commented

I was bit by this bug - I was able to work around it by not using multi-parent taxonomy terms (they weren't 100% necessary in my case). But a) thanks for folks for posting this, it was the post that helped me solve my problem, and b) I'll add a +1 for committing the patch.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Version: 7.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 969194-taxonomy-drag-drop-5.patch2.2 KB

@stockliasteroid, @Palantejon: thanks for confirming the bug and testing the patch. Unfortunately, bugs have to be fixed in the development branch first, so switching to 8.x-dev. Once it's committed in 8.x, it can be backported to 7.x.

8.x patch attached...

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

#5: 969194-taxonomy-drag-drop-5.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 969194-taxonomy-drag-drop-5.patch, failed testing.

cilefen’s picture

cilefen commented
Issue summary: View changes
Issue tags: +Needs backport to D7

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Title: Drag n Drop Only Partially Disabled When Term Has Multiple Parents » Drag’n’drop only partially disabled when term has multiple parents
Status: Needs work » Closed (outdated)

This appears to be fixed as of v8.5.x (at least).

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Version: 8.5.x-dev » 7.x-dev
Status: Closed (outdated) » Needs work
Issue tags: -Needs backport to D7

Actually, this still might be a valid bug report against 7.x

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.