If you have "allow_call_time_pass_reference = on" in your PHP settings using PHP 5.2+ you get the following error:

Warning: Call-time pass-by-reference has been deprecated in /[my webroot]/sites/all/modules/tweetbutton/tweetbutton_views_field_handlers.inc on line 24

Pretty sure this will create a warning in PHP 5.3 as calling by reference is now only done in the function definition: http://php.net/manual/en/language.references.pass.php

Attached is a patch.

CommentFileSizeAuthor
tweetbutton_reference_error.patch728 bytesacouch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dddave’s picture

dddave CreditAttribution: dddave commented
Status: Active » Needs review

Unless there is a better way to solve this (cannot judge) this patch works fine. If someone else confirms this the person can set the status to RTBC.

GiorgosK’s picture

GiorgosK
Location Chios, Greece 🇬🇷
CreditAttribution: GiorgosK commented
Status: Needs review » Reviewed & tested by the community

works as advertised
trivial change

chia’s picture

chia CreditAttribution: chia commented
Status: Reviewed & tested by the community » Fixed

fixed in dev branch,
Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.