simple cache + pagers = broken pager

This patch seems to resolve the problem for me. Cached panels with pagers now work again. Thanks!

Fixed this problem for me, thanks a million!

Committed to d6 and d7.

My experience with this indicates that this bug is not 100% fixed. I must still wait the 'Lifetime' of the Simple cache before the pager will move to another page. The url links of the pager are correct but the page displayed stays the same when clicked. I have tried all the cache granularities (Arguments, Context, None) and none of them work as expected. I am normally using a 'Page' type display in my underlying view, but I did check using a 'Content pane' and it also did not page with Simple cache enabled.

When I change Simple Cache to 'No caching' then the pager does page correctly.

Another problem, it doesn't verify that $_GET['page'] exists before adding it to the $id, it should be:

    $id .= ':p' . (empty($_GET['page']) ? '0' : check_plain($_GET['page']));

Here's a patch of the code from #7 for D7, and it fixes the formatting of the if() statement.

This still doesn't work if the item being displayed has a pager that isn't overridden by the display.

I committed a patch earlier that just brute-force checks $_PAGE -- it is less efficient but it guarantees pagers will not be ignored.

The current code again ignores situations where you're using a pager from the pane's content itself (Views, custom content types, etc) rather than controlling it in the pane; it also doesn't identify whether the pager is for the current pane so would needlessly reload certain data. I think we have three options:

• Continue improving the logic here, starting with making it properly aware of the pane's individual pager.
• Change Panels to be aware of there being a pager at all - this can be identified from Views and perhaps the CTools content type plugin API could be extended to indicate that a pager exists.
• Mark this is a known issue and document the behavior.

Also this does not take into account a pager ID which could be different

FYI Panels Hash Cache looks like it might be the best current option for Panels caching, though I've not tested it yet.