This can be seen in at: #overlay=admin/structure/types/manage/page
The auto_nodetitle module adds a token menu to the vertical tabs area.
The theme that reproduces this problem is Seven.

The expandable token groups, such as 'Current page' or 'Current user', fall outside of the table.
The problem seems to be that there is an inline css that has: style='margin-left: -19px; padding-left: 19px;'

Getting this to look correct requires deleting the margin-left: -19px entirely from jquery.treeTable.js file on line 221 inside the initialize function.

My original idea was to just write an exception case CSS, but because this javascript injects inline-css it cannot be overridden.

Files: 
CommentFileSizeAuthor
#21 jquery_treetable_js-961130-21.patch938 bytesnileshlohar
#20 jquery_treetable_js-961130-20.patch944 bytessylus
PASSED: [[SimpleTest]]: [MySQL] 347 pass(es). View
#17 token-tree-ui-fix-961130.patch794 bytesNaX
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in token-tree-ui-fix-961130.patch. View
#12 token-table-indent-chrome.png211.9 KBcleaver
#11 token_indent-961130-11.patch779 bytescleaver
PASSED: [[SimpleTest]]: [MySQL] 296 pass(es). View
#7 Seven_leaf_expanded.png56.31 KBhass
#5 961130-bartik.png46.54 KBthekevinday
#5 961130-garland.png26.91 KBthekevinday
#5 961130-seven.png30.88 KBthekevinday
#5 961130-stark.png41.97 KBthekevinday
#3 961130-bartik.png46.51 KBthekevinday
#3 961130-garland.png26.83 KBthekevinday
#3 961130-seven.png30.82 KBthekevinday
#3 961130-stark.png44.57 KBthekevinday
#1 token_d7_alignments.patch1.17 KBhass
PASSED: [[SimpleTest]]: [MySQL] 150 pass(es). View

Comments

hass’s picture

Version: 7.x-1.0-alpha3 » 7.x-1.x-dev
Priority: Minor » Normal
Status: Active » Needs review
FileSize
1.17 KB
PASSED: [[SimpleTest]]: [MySQL] 150 pass(es). View

Patch attached. It fixes the wrong table allignment and moves the image inside the table.

Dave Reid’s picture

Issue tags: +Needs screenshots

Needs screenshots on Bartik, Garland, and Seven themes in D7.

thekevinday’s picture

FileSize
44.57 KB
30.82 KB
26.83 KB
46.51 KB
hass’s picture

@thekevinday: I guess he mean with the patch applied :-)

I can confirm seven works well with the patch

thekevinday’s picture

FileSize
41.97 KB
30.88 KB
26.91 KB
46.54 KB

Well, try these then.

Dave Reid’s picture

Sorry, I should have included screenshots should include a leaf expanded ... last time we tried this simple fix it looked like crap.

hass’s picture

FileSize
56.31 KB

For me this looks good in seven.

Dave Reid’s picture

Status: Needs review » Needs work

Not really. The [user:created:custom:?] token should be indented past [user:created:custom] since it's the next level.

hass’s picture

The structure Looks completly the same without the patch. There is no [user:created:custom]. I'm confused...

hass’s picture

I have also tested the patch on D6 with latest tokens DEV and it works as it should with the patch applied. UI looks good with patch, but had the same issues like D7 without the patch. Tested with my YAML theme. The patch above applies also to D6-DEV with an offset.

cleaver’s picture

Status: Needs work » Needs review
FileSize
779 bytes
PASSED: [[SimpleTest]]: [MySQL] 296 pass(es). View

I've got a patch that addresses the problem by adding a class on the first column and adding some padding. On it's own, the negative margin in the tree-table makes sense, so I found it better to address with the table.

cleaver’s picture

Here's what it should look like after (Chrome / OSX):

Status: Needs review » Needs work
Issue tags: -Needs screenshots

The last submitted patch, token_indent-961130-11.patch, failed testing.

cleaver’s picture

Status: Needs work » Needs review
Issue tags: +Needs screenshots

#11: token_indent-961130-11.patch queued for re-testing.

Dave Reid’s picture

Hrm, the most recent patch doesn't seem to fix the fact that the table itself is indented to the left, which is mostly what we're trying to fix as well.

NaX’s picture

You should see this duplicate issue from tarekdj #1423022: margin problem with replacement patterns table

Including the below change in the above patch fixes it for me.

 .token-tree {
   font-size: 0.85em;
-  margin-left: 19px;
 }
NaX’s picture

FileSize
794 bytes
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in token-tree-ui-fix-961130.patch. View

Here is a how I am doing it. It includes the patch from #11 and part of the patch from #1423022: margin problem with replacement patterns table

Status: Needs review » Needs work
Issue tags: -Needs screenshots

The last submitted patch, token-tree-ui-fix-961130.patch, failed testing.

sylus’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs screenshots
FileSize
944 bytes
PASSED: [[SimpleTest]]: [MySQL] 347 pass(es). View

Attaching proper patch format against latest dev.

nileshlohar’s picture

With patch in #20 we are unable to expand the token group in available Tokens table.
So, updated the patch.

Interdiff :
added back $row['id'] = _token_clean_css_identifier($token);

naveenvalecha’s picture

Status: Needs review » Needs work

but $row['id'] = _token_clean_css_identifier($token); is not in the patch. Could you re-roll the patch?

//Naveen

nileshlohar’s picture

Status: Needs work » Needs review

@naveenvalecha: It's already there.

$row['id'] = _token_clean_css_identifier($token); Is already in the code at line 201 and was removed in patch #20
So, I removed that exclusion in #21

Hope it clears the confusion.