This can be seen in at: #overlay=admin/structure/types/manage/page
The auto_nodetitle module adds a token menu to the vertical tabs area.
The theme that reproduces this problem is Seven.
The expandable token groups, such as 'Current page' or 'Current user', fall outside of the table.
The problem seems to be that there is an inline css that has: style='margin-left: -19px; padding-left: 19px;'
Getting this to look correct requires deleting the margin-left: -19px
entirely from jquery.treeTable.js file on line 221 inside the initialize function.
My original idea was to just write an exception case CSS, but because this javascript injects inline-css it cannot be overridden.
Comment | File | Size | Author |
---|---|---|---|
#21 | jquery_treetable_js-961130-21.patch | 938 bytes | nileshlohar |
#7 | Seven_leaf_expanded.png | 56.31 KB | hass |
#5 | 961130-bartik.png | 46.54 KB | thekevinday |
#5 | 961130-garland.png | 26.91 KB | thekevinday |
#5 | 961130-seven.png | 30.88 KB | thekevinday |
Comments
Comment #1
hass CreditAttribution: hass commentedPatch attached. It fixes the wrong table allignment and moves the image inside the table.
Comment #2
Dave ReidNeeds screenshots on Bartik, Garland, and Seven themes in D7.
Comment #3
thekevinday CreditAttribution: thekevinday commentedComment #4
hass CreditAttribution: hass commented@thekevinday: I guess he mean with the patch applied :-)
I can confirm seven works well with the patch
Comment #5
thekevinday CreditAttribution: thekevinday commentedWell, try these then.
Comment #6
Dave ReidSorry, I should have included screenshots should include a leaf expanded ... last time we tried this simple fix it looked like crap.
Comment #7
hass CreditAttribution: hass commentedFor me this looks good in seven.
Comment #8
Dave ReidNot really. The [user:created:custom:?] token should be indented past [user:created:custom] since it's the next level.
Comment #9
hass CreditAttribution: hass commentedThe structure Looks completly the same without the patch. There is no [user:created:custom]. I'm confused...
Comment #10
hass CreditAttribution: hass commentedI have also tested the patch on D6 with latest tokens DEV and it works as it should with the patch applied. UI looks good with patch, but had the same issues like D7 without the patch. Tested with my YAML theme. The patch above applies also to D6-DEV with an offset.
Comment #11
cleaver CreditAttribution: cleaver commentedI've got a patch that addresses the problem by adding a class on the first column and adding some padding. On it's own, the negative margin in the tree-table makes sense, so I found it better to address with the table.
Comment #12
cleaver CreditAttribution: cleaver commentedHere's what it should look like after (Chrome / OSX):
Comment #14
cleaver CreditAttribution: cleaver commented#11: token_indent-961130-11.patch queued for re-testing.
Comment #15
Dave ReidHrm, the most recent patch doesn't seem to fix the fact that the table itself is indented to the left, which is mostly what we're trying to fix as well.
Comment #16
NaX CreditAttribution: NaX commentedYou should see this duplicate issue from tarekdj #1423022: margin problem with replacement patterns table
Including the below change in the above patch fixes it for me.
Comment #17
NaX CreditAttribution: NaX commentedHere is a how I am doing it. It includes the patch from #11 and part of the patch from #1423022: margin problem with replacement patterns table
Comment #20
sylus CreditAttribution: sylus commentedAttaching proper patch format against latest dev.
Comment #21
nileshlohar CreditAttribution: nileshlohar commentedWith patch in #20 we are unable to expand the token group in available Tokens table.
So, updated the patch.
Interdiff :
added back
$row['id'] = _token_clean_css_identifier($token);
Comment #22
naveenvalechabut
$row['id'] = _token_clean_css_identifier($token);
is not in the patch. Could you re-roll the patch?//Naveen
Comment #23
nileshlohar CreditAttribution: nileshlohar commented@naveenvalecha: It's already there.
$row['id'] = _token_clean_css_identifier($token);
Is already in the code at line 201 and was removed in patch #20So, I removed that exclusion in #21
Hope it clears the confusion.
Comment #24
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe 2 year old patch in #21 to token.css applied cleanly to the latest token 7.x-1.x-dev and if still applicable needs to be reviewed.